fix: address AI code quality findings across install scripts and utilities#84
Merged
Conversation
…ities - install.ps1: add error handling for GitHub API calls and downloads, verify extracted exe exists before move, fix PATH instruction quoting - install.sh: add jq support for JSON parsing with grep/sed fallback, validate version tag format, add explicit curl/wget check in download, improve /dev/tty readability check with fallback message - tests/test-utils.ts: consume stdout/stderr concurrently via Promise.all to prevent potential deadlock on large output - HeadSEO.astro: extract toBreadcrumbName() helper with special-case handling for acronyms (API, CLI, PT-BR), simplify markdownUrl ternary
Deploying archgate-cli with
|
| Latest commit: |
2c92643
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bc5145db.archgate-cli.pages.dev |
| Branch Preview URL: | https://claude-naughty-almeida.archgate-cli.pages.dev |
Rename windows-smoke-test.yml → smoke-test.yml and add: - install.ps1 smoke test on Windows (downloads real release, verifies binary) - install.sh smoke test on Linux (downloads real release, verifies binary) Both use ARCHGATE_VERSION env var to pin the version, avoiding GitHub API rate limits. Gracefully skip if no releases exist yet.
Merged
rhuanbarreto
added a commit
that referenced
this pull request
Mar 20, 2026
…ities (#84) * fix: address AI code quality findings across install scripts and utilities - install.ps1: add error handling for GitHub API calls and downloads, verify extracted exe exists before move, fix PATH instruction quoting - install.sh: add jq support for JSON parsing with grep/sed fallback, validate version tag format, add explicit curl/wget check in download, improve /dev/tty readability check with fallback message - tests/test-utils.ts: consume stdout/stderr concurrently via Promise.all to prevent potential deadlock on large output - HeadSEO.astro: extract toBreadcrumbName() helper with special-case handling for acronyms (API, CLI, PT-BR), simplify markdownUrl ternary * test: add install script smoke tests to CI Rename windows-smoke-test.yml → smoke-test.yml and add: - install.ps1 smoke test on Windows (downloads real release, verifies binary) - install.sh smoke test on Linux (downloads real release, verifies binary) Both use ARCHGATE_VERSION env var to pin the version, avoiding GitHub API rate limits. Gracefully skip if no releases exist yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invoke-RestMethod) and downloads (Invoke-WebRequest), verifyarchgate.exeexists after extraction before attemptingMove-Item, fix$InstallDirquoting in manual PATH instructionjqsupport for JSON parsing withgrep/sedfallback, validate version tag format, add explicitcurl/wgetavailability check in download step, improve/dev/ttyreadability check with graceful fallbackPromise.allto prevent potential deadlock when subprocess writes large outputtoBreadcrumbName()helper with special-case handling for acronyms (API, CLI, PT-BR), simplify complexmarkdownUrlternary into intermediate variablesFindings skipped (not valid)
safeRmSync→rmSyncWithRetry: Purely cosmetic, name already communicates intentTest plan
bun run validatepasses (lint, typecheck, format, tests, ADR check, build)