fix: remove stale MCP server configs from editor settings#53
Merged
Conversation
The `archgate mcp` command was removed in #50, but the VS Code and Copilot settings helpers still generated mcp.json files pointing to it. This caused broken MCP server entries when running `archgate init`. - Remove ARCHGATE_VSCODE_MCP_CONFIG and mcp.json generation from vscode-settings.ts (marketplace URL logic preserved) - Remove ARCHGATE_COPILOT_MCP_CONFIG and mcp.json generation from copilot-settings.ts - Update init-project.ts comment - Update tests to assert mcp.json is no longer created Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ARCHGATE_VSCODE_MCP_CONFIGand.vscode/mcp.jsongeneration fromvscode-settings.ts(marketplace URL logic preserved)ARCHGATE_COPILOT_MCP_CONFIGand.github/copilot/mcp.jsongeneration fromcopilot-settings.tsinit-project.tscomment referencing MCPmcp.jsonis no longer createdThe
archgate mcpcommand was removed in #50, but these editor settings helpers still generatedmcp.jsonfiles pointing to the removed command, producing broken MCP server entries onarchgate init.Test plan
bun test tests/helpers/vscode-settings.test.ts- all passbun test tests/helpers/copilot-settings.test.ts- all passbun test tests/helpers/init-project.test.ts- all passbun test tests/helpers/cursor-settings.test.ts- all pass (no changes, regression check)bun run validate- lint, typecheck, format, tests all pass