fix(ci): detect workflow changes that affect shim tests#360
Merged
Conversation
The shim-changes detection job only checked for file changes under shims/, missing changes to the workflow files themselves (e.g., action version bumps, runtime version changes). This meant a Renovate PR bumping Ruby 3.3→3.4 in the shim-tests job would skip tests entirely. Extend the git diff paths to also include publish-shims.yml and code-pull-request.yml so shim tests run when their CI infrastructure changes. Signed-off-by: Rhuan Barreto <rhuan@barreto.work>
Contributor
Code Coverage
Full HTML report available in workflow artifacts. Per-directory breakdown
|
Deploying archgate-cli with
|
| Latest commit: |
cc62d03
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4cc781c1.archgate-cli.pages.dev |
| Branch Preview URL: | https://fix-shim-changes-detect-work.archgate-cli.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shim-changesdetection job only checkedgit diff ... -- shims/, missing changes to the workflow files that configure shim test infrastructurecode-pull-request.ymlandpublish-shims.yml, but because those files are under.github/workflows/(notshims/), the detector outputsshims_changed=falseand all shim tests are skipped.github/workflows/publish-shims.ymland.github/workflows/code-pull-request.ymlso shim tests run when their CI infrastructure changesTest plan
code-pull-request.ymlitself changed)