fix(ci): pin proto 0.56.3 on Windows, restore node 24#299
Merged
Conversation
Restore node = "24" in .prototools — the problem was never Node, it was proto 0.56.4. Pin proto to 0.56.3 in the Windows smoke test workflow to avoid the starbase_archive 0.13.0 regression that prevents Node 24 from extracting on Windows Server 2025 runners. Remove the proto pin once proto 0.57+ ships with the fix. See: moonrepo/proto#1006 Signed-off-by: Rhuan Barreto <rhuan@barreto.work>
Deploying archgate-cli with
|
| Latest commit: |
6a20fc5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://877cb752.archgate-cli.pages.dev |
| Branch Preview URL: | https://fix-pin-proto-windows.archgate-cli.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores
node = "24"in.prototoolsand pins proto to0.56.3in the Windows smoke test instead.The previous fix (#296) downgraded Node to 22 as a workaround, but the root cause is a regression in proto 0.56.4 — specifically the
starbase_archive0.12.7 → 0.13.0 upgrade (commitd1f5e10e) which breaks Node 24 zip extraction on Windows Server 2025 runners.Pinning proto to the last pre-regression version is the correct fix since the problem is in proto, not Node. The pin should be removed once proto 0.57+ ships (PR moonrepo/proto#1001 has the fix).
Changes
.prototools— restorenode = "24"(was incorrectly downgraded to 22).github/workflows/smoke-test-windows.yml— addproto-version: "0.56.3"to setup-toolchainReferences