fix: address valid AI quality findings#202
Merged
Merged
Conversation
Fix truncated Portuguese word 'coment' → 'comentários' in the Sentry study translation, and improve plugin auto-install observability by logging errors via logDebug when catch blocks fall through to manual instructions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying archgate-cli with
|
| Latest commit: |
b0face8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f2e2cd4c.archgate-cli.pages.dev |
| Branch Preview URL: | https://fix-ai-quality-findings.archgate-cli.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed all 12 AI findings from GitHub's Code Quality AI scanner and triaged them by validity. This PR addresses the ones worth fixing:
coment→comentáriosin the Sentry study translation tablelogDebug()calls to the three silent catch blocks intryInstallPlugin()(Cursor, Copilot, Claude) so auto-install failures are visible in debug mode while preserving the intentional fall-through to manual URLs{ installed: false }return now includes adetailexplaining why installation was skippedDismissed findings (not addressed)
Bun.envwithprocess.envinpaths.tsBun.envin allsrc/filesfindProjectRootdirname()terminates at filesystem root (parent === dir), no infinite loop possibleurl.test.tsrandomUUIDin test uniqueIdDate.now() + Math.random()is adequate for test isolationTest plan
bun run validatepasses (lint, typecheck, format, 603 tests, ADR check, build)process.envinsrc/)🤖 Generated with Claude Code