feat: Add change passphrase to web clients (#114)#115
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds “Change Passphrase” functionality to the various web-based wallet/keymaster UIs so users can re-encrypt their wallet mnemonic under a new passphrase from the client.
Changes:
- Add a
changePassphrase()action + UI button to the legacyKeymasterUI.jsclients (keymaster + gatekeeper). - Add a “Change Passphrase” button and passphrase-entry modal wiring to the React Wallet app.
- Add a “Change Passphrase” button and passphrase-entry modal wiring to the Chrome Extension wallet.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| services/keymaster/client/src/KeymasterUI.js | Adds a prompt-driven passphrase change flow and a “Change Passphrase…” button in the wallet tab. |
| services/gatekeeper/client/src/KeymasterUI.js | Mirrors the same prompt-driven passphrase change flow and UI button. |
| apps/react-wallet/src/components/WalletTab.tsx | Adds PassphraseModal-based change-passphrase UX and updates session passphrase on success. |
| apps/chrome-extension/src/components/WalletTab.tsx | Adds PassphraseModal-based change-passphrase UX and stores updated passphrase via extension messaging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Fix import formatting (spaces inside braces) - Rename confirm to confirmPassphrase to avoid shadowing window.confirm - Use showError instead of window.alert for consistency with snackbar UX Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.