fix(scraper): support hash-routed spa crawling (#379)#380
Open
fix(scraper): support hash-routed spa crawling (#379)#380
Conversation
There was a problem hiding this comment.
Pull request overview
Drafts an OpenSpec change plan to add opt-in support for preserving hash fragments during web crawling so hash-routed SPA documentation sites can be discovered and indexed correctly (issue #379).
Changes:
- Adds OpenSpec proposal/design/spec for a
--preserve-hashes/preserveHashesoption. - Defines implementation tasks covering CLI/config wiring, URL normalization changes, Playwright interception adjustments, and tests.
- Introduces OpenSpec metadata for the change package.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| openspec/changes/support-hash-routed-spas/.openspec.yaml | Registers the change package with schema + creation date. |
| openspec/changes/support-hash-routed-spas/design.md | Documents goals, decisions, and risks for hash-route preservation and Playwright interception behavior. |
| openspec/changes/support-hash-routed-spas/proposal.md | Explains motivation, high-level approach, and impact of the new opt-in flag. |
| openspec/changes/support-hash-routed-spas/specs/hash-routed-spa-support/spec.md | Adds requirements/scenarios for preserving hashes, enforcing Playwright, and interception matching. |
| openspec/changes/support-hash-routed-spas/tasks.md | Breaks the implementation into concrete steps across config/CLI, core scraper, middleware, docs, and tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
openspec/changes/support-hash-routed-spas/specs/hash-routed-spa-support/spec.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 41 out of 41 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preserveHashessupport across CLI, MCP, web UI, pipeline, refresh, and stored scraper options for hash-routed SPA docs sitesfetchjobs toplaywrightwhen hash preservation is enabled, and cover refresh reuse/override plus redirect/interception edge cases in testsValidation