Support extras_require feature of setuptools.#45
Open
mishas wants to merge 2 commits intoapt-itude:repository-rule-per-distributionfrom
Open
Support extras_require feature of setuptools.#45mishas wants to merge 2 commits intoapt-itude:repository-rule-per-distributionfrom
mishas wants to merge 2 commits intoapt-itude:repository-rule-per-distributionfrom
Conversation
mishas
force-pushed
the
support_extras_requirements
branch
from
3e5508b to
5caf3a6
Compare
mishas
force-pushed
the
support_extras_requirements
branch
from
5caf3a6 to
85d044f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When defining extras for a requirement (e.g.
isort[pyproject]), the resulting requirement (in this caseisort) should have the relevant dependencies (in this casetoml).Implemented the feature, updated
//thirdparty/pip/requirements.in, locked on py2/py3 on both linux and macos, and added tests.