Skip to content

Clicking logo on /pricing to homepage-fixed #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PrabhakaranVijayan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clicking logo on /pricing to homepage-fixed #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions apps/web/src/components/landing-sections/navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,16 +78,18 @@ const Navbar = () => {
>
{isOpen ? <X size={28} /> : <Menu size={28} />}
</button>
<div className="text-xl md:text-2xl font-medium tracking-tighter flex items-center gap-2">
<div className="w-8 md:w-10 aspect-square overflow-hidden relative">
<Image
src="/assets/logo.svg"
alt="background"
fill
className="object-cover w-full h-full"
/>
</div>
<span>Opensox AI</span>
<div >
<Link href="/dashboard/home" className="text-xl md:text-2xl font-medium tracking-tighter flex items-center gap-2">
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

logo link target does not match the stated fix

Line 82 routes to /dashboard/home, but the PR objective says clicking the logo on /pricing should go to homepage. If homepage is the landing root, this should be /.

proposed fix 
-          <Link href="/dashboard/home" className="text-xl md:text-2xl font-medium tracking-tighter flex items-center gap-2">
+          <Link href="/" className="text-xl md:text-2xl font-medium tracking-tighter flex items-center gap-2">
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<Link href="/dashboard/home" className="text-xl md:text-2xl font-medium tracking-tighter flex items-center gap-2">
<Link href="/" className="text-xl md:text-2xl font-medium tracking-tighter flex items-center gap-2">
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@apps/web/src/components/landing-sections/navbar.tsx` at line 82, The logo
Link currently routes to "/dashboard/home" — update the href on the JSX Link
element (the <Link ... className="text-xl md:text-2xl font-medium
tracking-tighter flex items-center gap-2"> used for the logo) so clicking the
logo from pages like /pricing navigates to the landing homepage by changing the
target to "/".

<div className="w-8 md:w-10 aspect-square overflow-hidden relative">
<Image
src="/assets/logo.svg"
alt="background"
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

use meaningful alt text for the brand image

Line 86 uses alt="background", which is not descriptive for assistive tech.

proposed fix 
-                     alt="background"
+                     alt="Opensox logo"

As per coding guidelines, "Provide alt text for images".

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
alt="background"
alt="Opensox logo"
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@apps/web/src/components/landing-sections/navbar.tsx` at line 86, The brand
image in the Navbar component uses non-descriptive alt="background"; update the
<img> in the Navbar (component/function name: Navbar) to use meaningful alt text
(e.g., "YourBrand logo" or a descriptive label) or accept an alt prop and fall
back to a descriptive string so screen readers get useful context; locate the
<img> with alt="background" and replace it with a descriptive alt value or prop
usage.

fill
className="object-cover w-full h-full cursor-pointer"
/>
</div>
<span>Opensox AI</span>
</Link>
</div>
</div>
<div className="hidden min-[1115px]:flex items-center gap-5 max-[1270px]:gap-4 max-[1173px]:gap-3 tracking-tight text-lg max-[1270px]:text-base max-[1173px]:text-sm font-light max-[1173px]:font-normal text-[#d1d1d1]">
Expand Down