Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the LinkedTreeMap container class, which provides a map implementation with predictable iteration order for the NT kernel environment.
- Adds extensive unit tests covering all public methods of LinkedTreeMap
- Tests ordering behavior including insertion order preservation and update semantics
- Includes edge cases and move semantics validation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/LinkedTreeMapTest.cpp | New comprehensive test suite for LinkedTreeMap covering all public methods and ordering behaviors |
| test/CMakeLists.txt | Adds the new test file to the build configuration |
| include/kf/LinkedTreeMap.h | Code cleanup including constructor improvements and bug fixes in remove method |
| include/kf/GenericTableAvl.h | Suppresses deprecation warning for ExAllocatePoolWithTag |
| include/kf/DoubleLinkedList.h | Fixes move assignment operator to properly clear existing list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
bbb030b to
f7d259e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SergiusTheBest
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR have changes from this one with a fix for DoubleLinkedList: #57