Closed
Conversation
belyshevdenis
requested changes
Aug 12, 2025
Collaborator
belyshevdenis
left a comment
belyshevdenis
left a comment
There was a problem hiding this comment.
Please separate this PR to 2 PRs - for TimsorTest and AlgorithmTest
Collaborator
There was a problem hiding this comment.
Please rename to AlgorithmTest
Collaborator
There was a problem hiding this comment.
Please rename to TimsortTest
Collaborator
Author
Member
|
Closing it as we have separate PRs now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: https://jira.dev.local/jira/browse/KF-26
Rename ext to algorithm
Add tests for Algorithm
Add tests for test timsort
Also add nullptr checks for timsort functions to increase thiers stability, added a few comments and renamed some variables for better clarity.
Fix some methods, which performed not as expected