Improve utility classes Arrays and Colors #2
Conversation
- Refactor `Arrays.php` to avoid modifying array internal pointers by using `array_keys`, `array_values` and `array_search` instead of `next`/`prev`. - Optimize `Colors.php` `rgbToHex` conversion. - Add `Colors::hexToRgb` method. - Add unit tests for `Arrays` and `Colors`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This PR improves
ArraysandColorsutility classes.Arrays.phpmethods (getNextKey,getPreviousKey, etc.) were refactored to be stateless and avoid modifying the input array's internal pointer, which resolves side effects.Colors.phpnow includes ahexToRgbmethod andrgbToHeximplementation is simplified.Unit tests are added to cover these changes.
PR created automatically by Jules for task 8868814172312961610 started by @chemix