-
Notifications
You must be signed in to change notification settings - Fork 21
feat: Dart SDK update for version 20.0.0 #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
07b85ec
0097b6a
3a435b7
44fd34e
bfece00
a4839ee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,15 +10,15 @@ Sites sites = Sites(client); | |
| Site result = await sites.update( | ||
| siteId: '<SITE_ID>', | ||
| name: '<NAME>', | ||
| framework: .analog, | ||
| framework: Framework.analog, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Find the main SDK files and enum definitions
# First, let's see the repository structure
git ls-files | head -20
# Look for TypeScript/JavaScript enum definitions
fd -e ts -e js -e tsx -e jsx | grep -v node_modules | head -30Repository: appwrite/sdk-for-dart Length of output: 776 🏁 Script executed: #!/bin/bash
# Find Dart files with enum definitions
fd -e dart | grep -v pubspec | head -30
# Look for enum definitions in Dart files
rg -n "enum Framework\|enum BuildRuntime\|enum Adapter" --type dartRepository: appwrite/sdk-for-dart Length of output: 750 🏁 Script executed: #!/bin/bash
# Check the size of enums.dart
wc -l lib/enums.dart
# Read the entire file to find the enums
cat -n lib/enums.dartRepository: appwrite/sdk-for-dart Length of output: 1851 🏁 Script executed: #!/bin/bash
# Read the three enum files
echo "=== framework.dart ==="
cat -n lib/src/enums/framework.dart
echo -e "\n=== build_runtime.dart ==="
cat -n lib/src/enums/build_runtime.dart
echo -e "\n=== adapter.dart ==="
cat -n lib/src/enums/adapter.dartRepository: appwrite/sdk-for-dart Length of output: 3918 🏁 Script executed: #!/bin/bash
# Read the update.md file to see the actual enum usage
cat -n docs/examples/sites/update.mdRepository: appwrite/sdk-for-dart Length of output: 1418 The enum value The verification found that 🤖 Prompt for AI Agents |
||
| enabled: false, // (optional) | ||
| logging: false, // (optional) | ||
| timeout: 1, // (optional) | ||
| installCommand: '<INSTALL_COMMAND>', // (optional) | ||
| buildCommand: '<BUILD_COMMAND>', // (optional) | ||
| outputDirectory: '<OUTPUT_DIRECTORY>', // (optional) | ||
| buildRuntime: .node145, // (optional) | ||
| adapter: .static, // (optional) | ||
| buildRuntime: BuildRuntime.node145, // (optional) | ||
| adapter: Adapter.static, // (optional) | ||
| fallbackFile: '<FALLBACK_FILE>', // (optional) | ||
| installationId: '<INSTALLATION_ID>', // (optional) | ||
| providerRepositoryId: '<PROVIDER_REPOSITORY_ID>', // (optional) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove duplicate enum entries.
Line 7 claims to add
Theme,Timezone, andOutputenums in version 20.0.0, but Line 12 already documents these same enums as added in version 19.4.0. Enums cannot be added in two different versions.Please verify which version actually introduced these enums and remove the duplicate entry.
🤖 Prompt for AI Agents