fix(console): regional Projects API for service toggles + full ApiSer…#2976
fix(console): regional Projects API for service toggles + full ApiSer…#2976HarshMN2345 wants to merge 12 commits intomainfrom
Conversation
Greptile SummaryThis PR fixes service and protocol toggles to use the regional
Confidence Score: 4/5Safe to merge after fixing the missing Two P1 findings in the bulk-toggle loops: if any sequential API call fails, updateServices.svelte and updateProtocols.svelte — both need Important Files Changed
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
| { label: 'Functions', method: ApiService.Functions, value: null }, | ||
| { label: 'GraphQL', method: ApiService.Graphql, value: null }, | ||
| { label: 'Messaging', method: ApiService.Messaging, value: null } | ||
| ] satisfies Service[] |
There was a problem hiding this comment.
We are missing Migrations
Let's also ask AI to sort the list alphabetically
| { | ||
| label: 'Messaging', | ||
| method: ApiService.Messaging, | ||
| value: project.serviceStatusForMessaging |
There was a problem hiding this comment.
Missing migrations I think
|
|
||
| try { | ||
| await sdk.forConsole.projects.updateServiceStatusAll({ | ||
| await sdk.forConsoleIn($project.region).projects.updateServiceStatusAll({ |
There was a problem hiding this comment.
We no longer have updateServiceStatusAll. We need to loop them, and do "updateServiceStatus".
|
|
||
| try { | ||
| await sdk.forConsole.projects.updateServiceStatus({ | ||
| await sdk.forConsoleIn($project.region).projects.updateServiceStatus({ |
There was a problem hiding this comment.
We need new SDK and use project SDK, not projects.
| <svelte:fragment slot="aside"> | ||
| <div> | ||
| <Secret label="Key" copyEvent="signature" bind:value={$webhook.signatureKey} /> | ||
| <Secret label="Key" copyEvent="signature" bind:value={$webhook.secret} /> |
There was a problem hiding this comment.
You can no longer read secret - you only see it once after creating it, or after updating it
2 participants
…vice list
What does this PR do?
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)