Skip to content

fix: search and clear search behaviour in search query component #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaysomani wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: search and clear search behaviour in search query component #2668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions src/lib/components/searchQuery.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@
autofocus = false
}: Props = $props();

let inputValue = $state(page.url.searchParams.get('search') ?? '');
const initialSearch = page.url.searchParams.get('search') ?? '';
let inputValue = $state(initialSearch);
let previousInputValue = $state(initialSearch);
let previousUrlSearch = $state(initialSearch);

const runSearch = createDebounce((value: string) => {
const trimmed = value.trim();
Expand Down Expand Up @@ -54,11 +57,31 @@
runSearch.cancel?.();
});

// Sync URL → input when URL changes externally (e.g., Clear Search button)
$effect(() => {
const urlSearch = page.url.searchParams.get('search') ?? '';
if (urlSearch !== previousUrlSearch) {
previousUrlSearch = urlSearch;
if (urlSearch !== inputValue) {
inputValue = urlSearch;
previousInputValue = urlSearch;
}
}
});

if (urlSearch !== inputValue) {
runSearch(inputValue);
// Sync input → URL when user types (only when inputValue changes from user input)
$effect(() => {
if (inputValue !== previousInputValue) {
// Input changed - check if it's from user typing (not from URL sync)
const urlSearch = page.url.searchParams.get('search') ?? '';
if (inputValue !== urlSearch) {
// Input is different from URL - user is typing
previousInputValue = inputValue;
runSearch(inputValue);
} else {
// Input matches URL - was synced from URL, don't update
previousInputValue = inputValue;
}
}
});
</script>
Expand Down