Open
Conversation
Kotlin synthetics were also replaced with findViewById, since they are not available anymore. Avoided to migrate to view binding since a migration to Jetpack Compose would make more sense in the future.
Contributor
|
Hi @tpakis thanks a lot of making these changes to update the app to the latest standards. My holiday is starting in a couple days, I expect to check out these changes and publish a new version of the app in December. |
Author
|
Hi @JJdeGroot, sounds good thank you very much, have a nice holiday! P.S. I will open a similar PR for https://github.com/tpakis/screenreader-android in the following days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to find the appt app on Google Play Store, I saw that the app is not available for Android 16 devices. Even if the website content is complete and easily accessible, I wanted to see if there are more information on the app and how the app handles accessibility features on my device (Android 16).
To do this I updated the AGP, Kotlin version, compile/target sdk versions, removed synthetics (did not migrate to view binding or compose), handle back press changes with callbacks and mandatory edge-to-edge layout adjustments.