fix: XSS vulnurability in Table HTML cell#41539
Conversation
WalkthroughTwo utility files in TableWidgetV2 replaced innerHTML-based DOM manipulation with DOMParser API. One file extracts HTML tag names; the other extracts text content from HTML strings. Both changes maintain existing functionality while adopting a safer parsing mechanism. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/21738483119. |
|
Deploy-Preview-URL: https://ce-41539.dp.appsmith.com |
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes https://linear.app/appsmith/issue/V2-2922/critical-stored-xss-vulnerability-in-table-widget-allows-takeover
Fixes https://github.com/appsmithorg/appsmith/security/advisories/GHSA-5hw4-whxv-6794
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/21703384270
Commit: aabd52b
Cypress dashboard.
Tags:
@tag.SanitySpec:
Thu, 05 Feb 2026 08:33:21 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit