Skip to content

[DONOTMERGE]: Tuning Fixed layout for dense layouts #38376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riodeuno wants to merge 1 commit into
base: release
Choose a base branch
from
Open

[DONOTMERGE]: Tuning Fixed layout for dense layouts #38376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/client/src/constants/WidgetConstants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export const CONTAINER_GRID_PADDING =
*/
export const AUTO_LAYOUT_CONTAINER_PADDING = 5;

export const WIDGET_PADDING = GridDefaults.DEFAULT_GRID_ROW_HEIGHT * 0.4;
export const WIDGET_PADDING = 0;

export const WIDGET_CLASSNAME_PREFIX = "WIDGET_";
export const MAIN_CONTAINER_WIDGET_ID = "0";
Expand Down Expand Up @@ -193,7 +193,7 @@ export const DEFAULT_FONT_SIZE = THEMEING_TEXT_SIZES.base;
// This also makes sure that widgets have sufficient area in which users can interact.
export const WidgetHeightLimits = {
MAX_HEIGHT_IN_ROWS: 9000,
MIN_HEIGHT_IN_ROWS: 4,
MIN_HEIGHT_IN_ROWS: 1,
MIN_CANVAS_HEIGHT_IN_ROWS: 10,
};

Expand Down
4 changes: 2 additions & 2 deletions app/client/src/widgets/TextWidget/widget/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ class TextWidget extends BaseWidget<TextWidgetProps, WidgetState> {
return {
text: "Hello {{appsmith.user.name || appsmith.user.email}}",
fontSize: DEFAULT_FONT_SIZE,
fontStyle: "BOLD",
fontStyle: "REGULAR",
textAlign: "LEFT",
textColor: "#231F20",
rows: 4,
rows: 1,
columns: 16,
widgetName: "Text",
shouldTruncate: false,
Expand Down
Loading