feat: Configurable init container images by kvandenhoute · Pull Request #32845 · appsmithorg/appsmith

kvandenhoute · 2024-04-22T09:26:01Z

Description

This PR enables configurable init container images.
In line with other images in this chart, this PR makes sure you can configure registry, repository and tag all separately.
It also adds a imagePullPolicy.
To ensure backwards compatibility I left the redis.image and mongodb.image properties in there. But imho these should be removed in a future major chart version.

Fixes #32844

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

New Features
- Enhanced Helm chart configurations to allow customizable image references and pull policies for Redis and MongoDB init containers.

coderabbitai · 2024-04-22T09:26:11Z

Walkthrough

The recent update to the Helm chart introduces configurable image references and pull policies for Redis and MongoDB init containers. This enhancement allows users to specify registry, repository, tag, and pull policy for each container, improving flexibility and compatibility with custom registries.

Changes

File Path	Change Summary
`deploy/helm/README.md`	Updated documentation to reflect new configurable init container settings.
`deploy/helm/.../statefulset.yaml`	Modified to support configurable image references and pull policies.
`deploy/helm/values.yaml`	Restructured to allow separate settings for registry, repository, and tag.

Assessment against linked issues

Objective	Addressed	Explanation
Configurability of initContainer images (registry, repository, tag, pull policy) [#32844]	✅
Backwards compatibility with existing `redis.image` and `mongodb.image` properties [#32844]	✅
Removal of redundant properties in a future major chart version [#32844]	❓	The PR does not specify a timeline or version for the removal of these properties.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6d90ce8 and e963b89.

Files selected for processing (3)

deploy/helm/README.md (1 hunks)
deploy/helm/templates/statefulset.yaml (1 hunks)
deploy/helm/values.yaml (1 hunks)

Additional Context Used

LanguageTool (232)

deploy/helm/README.md (232)

Near line 2: Possible typo: you repeated a word
Context: # Appsmith Appsmith is a JS-based internal tool development...

Near line 3: Possible spelling mistake found.
Context: ...user access management. Developers love Appsmith because it saves them hundreds of hours...

Near line 7: This word is normally spelled as one.
Context: ...: PostgreSQL, MongoDB, MySQL, Redshift, Elastic Search, DynamoDB, Redis, & MSFT SQL Server. ##...

Near line 20: The verb form ‘bootstrap’ does not appear to fit in this context.
Context: ...rate-name ``` ## Introduction --- This chart bootstrap an [Appsmith](https://github.com/appsmi...

Near line 20: Possible spelling mistake found.
Context: ...troduction --- This chart bootstrap an [Appsmith](https://github.com/appsmithorg/appsmit...

Near line 24: Unpaired symbol: ‘]’ seems to be missing
Context: ...tes --- * Install Helm package manager: [https://helm.sh/docs/intro/install/](htt...

Near line 25: Possible spelling mistake found.
Context: ...//helm.sh/docs/intro/install/) * Ensure kubectl is installed and configured to connect...

Near line 26: Possible spelling mistake found.
Context: ...o connect to your cluster * Install kubectl: [kubernetes.io/vi/docs/tasks/tools/ins...

Near line 26: Unpaired symbol: ‘]’ seems to be missing
Context: ... to your cluster * Install kubectl: [kubernetes.io/vi/docs/tasks/tools/instal...

Near line 27: Possible spelling mistake found.
Context: ...ocs/tasks/tools/install-kubectl/) * Minikube: [Setup Kubectl](https://minikube.sigs....

Near line 27: Unpaired symbol: ‘]’ seems to be missing
Context: ...tools/install-kubectl/) * Minikube: [Setup Kubectl](https://minikube.sigs.k8s...

Near line 27: Possible spelling mistake found.
Context: ...nstall-kubectl/) * Minikube: [Setup Kubectl](https://minikube.sigs.k8s.io/docs/hand...

Near line 28: Unpaired symbol: ‘]’ seems to be missing
Context: ...ubectl/) * Google Cloud Kubernetes: [Configuring cluster access for kubectl](...

Near line 28: Possible spelling mistake found.
Context: ...rnetes: [Configuring cluster access for kubectl](https://cloud.google.com/kubernetes-en...

Near line 29: Possible spelling mistake found.
Context: ...ow-to/cluster-access-for-kubectl) * Aws EKS: [Create a kubeconfig for Amazon EK...

Near line 29: Unpaired symbol: ‘]’ seems to be missing
Context: ...ster-access-for-kubectl) * Aws EKS: [Create a kubeconfig for Amazon EKS](http...

Near line 29: Possible spelling mistake found.
Context: ...s-for-kubectl) * Aws EKS: [Create a kubeconfig for Amazon EKS](https://docs.aws.amazon...

Near line 31: Possible typo detected.
Context: ...serguide/create-kubeconfig.html) * Microk8s: [Working with kubectl](https://microk8...

Near line 31: Unpaired symbol: ‘]’ seems to be missing
Context: ...reate-kubeconfig.html) * Microk8s: [Working with kubectl](https://microk8s.i...

Near line 31: Possible spelling mistake found.
Context: ...ig.html) * Microk8s: [Working with kubectl](https://microk8s.io/docs/working-with-...

Near line 33: Possible spelling mistake found.
Context: ...ge class in case of no existing one * Minikube: [Enable addon default-storageclass](ht...

Near line 33: Unpaired symbol: ‘]’ seems to be missing
Context: ...n case of no existing one * Minikube: [Enable addon default-storageclass](https...

Near line 33: Possible spelling mistake found.
Context: ...f no existing one * Minikube: [Enable addon default-storageclass](https://kubernete...

Near line 33: Possible spelling mistake found.
Context: ...xisting one * Minikube: [Enable addon default-storageclass](https://kubernetes.io/docs/tutorials/h...

Near line 34: Unpaired symbol: ‘]’ seems to be missing
Context: ...le-addons) * Google Cloud Kubernetes: [Setting up default storage class on GKE]...

Near line 35: Unpaired symbol: ‘]’ seems to be missing
Context: ...-to/default-storage-class) * AWS EKS: [Create default storage class](https://do...

Near line 36: Possible typo detected.
Context: ...est/userguide/storage-classes.html) * Microk8s: [Enable storage](https://microk8s.io/d...

Near line 36: Unpaired symbol: ‘]’ seems to be missing
Context: ...ide/storage-classes.html) * Microk8s: [Enable storage](https://microk8s.io/docs...

Near line 37: There may an error in the verb form ‘be enable’.
Context: ...ernetes NGINX Ingress Controller should be enable on your cluster by default. Please make...

Near line 37: Consider using a different verb to strengthen your wording.
Context: ...able on your cluster by default. Please make sure that you install the right version for ...

Near line 38: Possible spelling mistake found.
Context: ...he right version for your cluster * Minikube: [Set up Ingress on Minikube with the N...

Near line 38: Unpaired symbol: ‘]’ seems to be missing
Context: ...ersion for your cluster * Minikube: [Set up Ingress on Minikube with the NGIN...

Near line 38: Possible spelling mistake found.
Context: ...ster * Minikube: [Set up Ingress on Minikube with the NGINX Ingress Controller](http...

Near line 39: Unpaired symbol: ‘]’ seems to be missing
Context: ...nikube/) * Google Cloud Kubernetes: [Ingress with NGINX controller on Google ...

Near line 40: Unpaired symbol: ‘]’ seems to be missing
Context: ...o/ingress-nginx/deploy/) * AWS EKS: [Install NGINX Controller for AWS EKS](ht...

Near line 41: Possible typo detected.
Context: ...eploy/#network-load-balancer-nlb) * Microk8s: [Add on: Ingress](https://microk8s.io/...

Near line 41: Unpaired symbol: ‘]’ seems to be missing
Context: ...work-load-balancer-nlb) * Microk8s: [Add on: Ingress](https://microk8s.io/doc...

Near line 48: Possible spelling mistake found.
Context: ...--generate-name ``` The command deploys Appsmith application on Kubernetes cluster in th...

Near line 51: Possible spelling mistake found.
Context: ...stalling the Chart --- To uninstall the appsmith release: ``` helm list NAME ...

Near line 64: Possible typo: you repeated a whitespace
Context: ...### Global parameters | Name | Description | ...

Near line 66: Possible spelling mistake found.
Context: ...------------------------- | ------- | | global.namespaceOverride | Override the namespace for resource ...

Near line 66: Possible typo: you repeated a whitespace
Context: ...or resource deployed by the chart | "" | | global.storageClass | Global S...

Near line 67: Possible spelling mistake found.
Context: ...urce deployed by the chart | "" | | global.storageClass | Global StorageClass for Persisten...

Near line 67: Possible typo: you repeated a whitespace
Context: ...art | "" | | global.storageClass | Global StorageClass for Persistent Vol...

Near line 67: Possible spelling mistake found.
Context: ... | | global.storageClass | Global StorageClass for Persistent Volume(s) | "" ...

Near line 67: Possible typo: you repeated a whitespace
Context: ...s for Persistent Volume(s) | "" | ### Common parameters | Name ...

Near line 72: Possible spelling mistake found.
Context: ...------------------- | ------------- | | fullnameOverride | String to fully override `appsmith....

Near line 72: Possible typo: you repeated a whitespace
Context: ...- | ------------- | | fullnameOverride | String to fully override `appsmith.nam...

Near line 72: Possible typo: you repeated a whitespace
Context: ...override appsmith.name template | "" | | containerName | Specify cont...

Near line 73: Possible spelling mistake found.
Context: ...appsmith.nametemplate |"" | | containerName` | Specify container's name running i...

Near line 73: Possible spelling mistake found.
Context: ...ontainer's name running in the pods | "appsmith" | | commonLabels | Labels to ...

Near line 74: Possible spelling mistake found.
Context: ...nning in the pods | "appsmith" | | commonLabels | Labels to add to all deployed o...

Near line 74: Possible typo: you repeated a whitespace
Context: ...ods | "appsmith" | | commonLabels | Labels to add to all deployed objects ...

Near line 75: Possible spelling mistake found.
Context: ... deployed objects | {} | | commonAnnotations | Annotations to add to all deployed o...

Near line 77: Possible spelling mistake found.
Context: ...deployed objects | {} | ### Appsmith Image parameters | Name | Descr...

Near line 78: Possible typo: you repeated a whitespace
Context: ...| Description | Value | | ------------------- | --------------...

Near line 80: Possible spelling mistake found.
Context: ...----------------| | image.registry | Appsmith image registry | index.docker.io ...

Near line 80: Possible typo: you repeated a whitespace
Context: ...mage registry | index.docker.io | | image.repository | Appsmith image ...

Near line 81: Possible spelling mistake found.
Context: ...ker.io | |image.repository | Appsmith image repository | appsmith/appsmith-...

Near line 81: Possible spelling mistake found.
Context: ...ository | Appsmith image repository | appsmith/appsmith-ce | |image.tag` | Ap...

Near line 81: Possible typo: you repeated a whitespace
Context: ...ge repository | appsmith/appsmith-ce | | image.tag | Appsmith image tag...

Near line 82: Possible spelling mistake found.
Context: ...th/appsmith-ce | |image.tag | Appsmith image tag | latest` ...

Near line 82: Possible typo: you repeated a whitespace
Context: ...smith image tag | latest | | image.pullPolicy | Appsmith image ...

Near line 83: Possible spelling mistake found.
Context: ... tag | latest | | image.pullPolicy | Appsmith image pull policy | `IfNotP...

Near line 83: Possible spelling mistake found.
Context: ... | | image.pullPolicy | Appsmith image pull policy | IfNotPresent ...

Near line 83: Possible spelling mistake found.
Context: ...lPolicy | Appsmith image pull policy | IfNotPresent | |initContainer.redis.reg...

Near line 83: Possible typo: you repeated a whitespace
Context: ...mage pull policy | IfNotPresent | | initContainer.redis.registry | Re...

Near line 84: Possible spelling mistake found.
Context: ...l policy | IfNotPresent | | initContainer.redis.registry | Redis image registry...

Near line 84: Possible typo: you repeated a whitespace
Context: ...edis image registry | docker.io | | initContainer.redis.repository | R...

Near line 85: Possible spelling mistake found.
Context: ...age registry | docker.io | | initContainer.redis.repository | Redis image reposit...

Near line 85: Possible spelling mistake found.
Context: ...repository | Redis image repository | bitnami/redis-cluster | |initContainer.red...

Near line 85: Possible typo: you repeated a whitespace
Context: ...e repository | bitnami/redis-cluster | | initContainer.redis.tag | Redi...

Near line 86: Possible spelling mistake found.
Context: ...sitory | bitnami/redis-cluster | | initContainer.redis.tag | Redis image tag | ...

Near line 86: Possible typo: you repeated a whitespace
Context: ...g | 7.0.13-debian-11-r10 | | initContainer.redis.pullPolicy | R...

Near line 87: Possible spelling mistake found.
Context: ...0.13-debian-11-r10 | |initContainer.redis.pullPolicy` | Redis image pull po...

Near line 87: Possible spelling mistake found.
Context: ...pullPolicy | Redis image pull policy | IfNotPresent | |initContainer.mongodb.r...

Near line 87: Possible typo: you repeated a whitespace
Context: ...mage pull policy | IfNotPresent | | initContainer.mongodb.registry | ...

Near line 88: Possible spelling mistake found.
Context: ...l policy | IfNotPresent | | initContainer.mongodb.registry | Mongodb image regi...

Near line 88: Possible spelling mistake found.
Context: ...| | initContainer.mongodb.registry | Mongodb image registry | docker.io |...

Near line 88: Possible typo: you repeated a whitespace
Context: ...godb image registry | docker.io | | initContainer.mongodb.repository |...

Near line 89: Possible spelling mistake found.
Context: ...age registry | docker.io | | initContainer.mongodb.repository | Mongodb image rep...

Near line 89: Possible spelling mistake found.
Context: ... | initContainer.mongodb.repository | Mongodb image repository | bitnami/mongodb ...

Near line 89: Possible spelling mistake found.
Context: ...pository | Mongodb image repository | bitnami/mongodb | |initContainer.mongodb.t...

Near line 89: Possible typo: you repeated a whitespace
Context: ...b image repository | bitnami/mongodb | | initContainer.mongodb.tag | Mo...

Near line 90: Possible spelling mistake found.
Context: ...e repository | bitnami/mongodb | | initContainer.mongodb.tag | Mongodb image tag ...

Near line 90: Possible spelling mistake found.
Context: ... | | initContainer.mongodb.tag | Mongodb image tag | 5.0.21-debian-11-r5 ...

Near line 90: Possible typo: you repeated a whitespace
Context: ...ag | 5.0.21-debian-11-r5 | | initContainer.mongodb.pullPolicy |...

Near line 91: Possible spelling mistake found.
Context: ....0.21-debian-11-r5 | |initContainer.mongodb.pullPolicy` | Mongodb image pul...

Near line 91: Possible spelling mistake found.
Context: ... | initContainer.mongodb.pullPolicy | Mongodb image pull policy | IfNotPresent ...

Near line 91: Possible spelling mistake found.
Context: ...llPolicy | Mongodb image pull policy | IfNotPresent` | ### Appsmith deployment p...

Near line 91: Possible typo: you repeated a whitespace
Context: ...mage pull policy | IfNotPresent | ### Appsmith deployment parameters | ...

Near line 93: Possible spelling mistake found.
Context: ...olicy | IfNotPresent | ### Appsmith deployment parameters | Name ...

Near line 94: Possible typo: you repeated a whitespace
Context: ... deployment parameters | Name | Description | Val...

Near line 96: Possible spelling mistake found.
Context: ...----------------- | --------------- | | strategyType | Appsmith deployment strategy t...

Near line 96: Possible spelling mistake found.
Context: ...------------ | | strategyType | Appsmith deployment strategy type | `Ro...

Near line 96: Possible spelling mistake found.
Context: ...ith deployment strategy type | RollingUpdate | | schedulerName | Alternate ...

Near line 97: Possible spelling mistake found.
Context: ...egy type | RollingUpdate | | schedulerName | Alternate scheduler ...

Near line 98: Possible spelling mistake found.
Context: ...heduler | "" | | podAnnotations | Annotations for Appsmith pods ...

Near line 98: Possible spelling mistake found.
Context: ...podAnnotations | Annotations for Appsmith pods | {} | | `podLab...

Near line 99: Possible spelling mistake found.
Context: ...ppsmith pods | {} | | podLabels | Labels for Appsmith pods ...

Near line 99: Possible spelling mistake found.
Context: ... | | podLabels | Labels for Appsmith pods | {} | | `podSec...

Near line 100: Possible spelling mistake found.
Context: ...ppsmith pods | {} | | podSecurityContext | Appsmith pods security context ...

Near line 100: Possible spelling mistake found.
Context: ...{} | | podSecurityContext | Appsmith pods security context | {} ...

Near line 101: Possible spelling mistake found.
Context: ...urity context | {} | | securityContext | Set security context ...

Near line 102: Possible spelling mistake found.
Context: ...it | The resources limits for the Appsmith container | {} | | resources....

Near line 103: Possible spelling mistake found.
Context: ...s | The requested resources for the Appsmith container | {} | | nodeSelector...

Near line 104: Possible spelling mistake found.
Context: ... the Appsmith container | {} | | nodeSelector | Node labels for pod assignment...

Near line 105: Possible spelling mistake found.
Context: ...od assignment | {} | | tolerations | Tolerations for pod assignmen...

Near line 105: Possible spelling mistake found.
Context: ... | {} | | tolerations | Tolerations for pod assignment | [] ...

Near line 106: Possible spelling mistake found.
Context: ... | | affinity | Affinity fod pod assignment | {} ...

Near line 108: Possible spelling mistake found.
Context: ...signment | {} | ### Appsmith service account parameters | Name ...

Near line 109: Possible typo: you repeated a whitespace
Context: ...ice account parameters | Name | Description ...

Near line 109: Possible typo: you repeated a whitespace
Context: ...tion | Value | | ---------------...

Near line 111: Possible spelling mistake found.
Context: ...------------------------- | ------- | | serviceAccount.create | Enable creation of `Serv...

Near line 111: Possible typo: you repeated a whitespace
Context: ...-- | ------- | | serviceAccount.create | Enable creation of ServiceAccount ...

Near line 111: Possible spelling mistake found.
Context: ...count.create | Enable creation ofServiceAccount` for Appsmith pods ...

Near line 111: Possible spelling mistake found.
Context: ...Enable creation of ServiceAccount for Appsmith pods | `tru...

Near line 111: Possible typo: you repeated a whitespace
Context: ...Accountfor Appsmith pods |true | |serviceAccou...

Near line 112: Possible typo: you repeated a whitespace
Context: ... | true | | serviceAccount.name | Name of the created ServiceAccount...

Near line 112: Possible spelling mistake found.
Context: ...ount.name | Name of the createdServiceAccount` . If not set, a name is generated usin...

Near line 112: Don’t put a space before the full stop.
Context: ... | Name of the created ServiceAccount . If not set, a name is generated using t...

Near line 112: Possible spelling mistake found.
Context: ... not set, a name is generated using the appsmith.fullname template | "" | | `service...

Near line 112: Possible spelling mistake found.
Context: ... a name is generated using the appsmith.fullname template | "" | | `serviceAccount.a...

Near line 113: Possible spelling mistake found.
Context: ...appsmith.fullname template | "" | | serviceAccount.annotations | Additional service acco...

Near line 113: Possible typo: you repeated a whitespace
Context: ...account annotations | {} | ### Traffic Exp...

Near line 116: Possible typo: you repeated a whitespace
Context: ...ic Exposure Parameters | Name | Description ...

Near line 116: Possible typo: you repeated a whitespace
Context: ...tion | Value | | -----------------------...

Near line 118: Possible typo: you repeated a whitespace
Context: ...- | ----------- | | service.type | Appsmith service type ...

Near line 118: Possible spelling mistake found.
Context: ...------ | | service.type | Appsmith service type ...

Near line 118: Possible typo: you repeated a whitespace
Context: ...rvice type | ClusterIP | | service.port ...

Near line 118: Possible spelling mistake found.
Context: ...ype | ClusterIP | | service.port | Appsmi...

Near line 119: Possible typo: you repeated a whitespace
Context: ... | ClusterIP | | service.port | Appsmith service port ...

Near line 119: Possible spelling mistake found.
Context: ...sterIP| |service.port` | Appsmith service port ...

Near line 119: Possible typo: you repeated a whitespace
Context: ...rvice port | 80 | | service.portName ...

Near line 120: Possible spelling mistake found.
Context: ... | 80 | | service.portName | Appsmith service port name...

Near line 120: Possible typo: you repeated a whitespace
Context: ... | 80 | | service.portName | Appsmith service port name ...

Near line 120: Possible spelling mistake found.
Context: ... | | service.portName | Appsmith service port name ...

Near line 120: Possible typo: you repeated a whitespace
Context: ...ce port name | appsmith | | service.nodePort ...

Near line 120: Possible spelling mistake found.
Context: ...t name | appsmith | | service.nodePort | Ap...

Near line 121: Possible spelling mistake found.
Context: ... | appsmith | | service.nodePort | Appsmith service node port...

Near line 121: Possible typo: you repeated a whitespace
Context: ...| appsmith | | service.nodePort | Appsmith service node port to exp...

Near line 121: Possible spelling mistake found.
Context: ...th | |service.nodePort` | Appsmith service node port to expose to expose ...

Near line 121: This phrase is duplicated. You should probably use “to expose” only once.
Context: ... | Appsmith service node port to expose to expose | `...

Near line 121: Possible typo: you repeated a whitespace
Context: ...th service node port to expose to expose | 8000 | | `service.clusterI...

Near line 121: Possible typo: you repeated a whitespace
Context: ... expose | 8000 | | service.clusterIP ...

Near line 122: Possible spelling mistake found.
Context: ... | 8000 | | service.clusterIP | Appsmith service Cluster...

Near line 122: Possible typo: you repeated a whitespace
Context: ... | 8000 | | service.clusterIP | Appsmith service Cluster ...

Near line 122: Possible spelling mistake found.
Context: ... | | service.clusterIP | Appsmith service Cluster ...

Near line 122: Possible typo: you repeated a whitespace
Context: ...ice Cluster | "" | | `service.loadBalancerIP...

Near line 123: Possible spelling mistake found.
Context: ... | "" | | service.loadBalancerIP | Appsmith service Load Balance...

Near line 123: Possible typo: you repeated a whitespace
Context: ... | "" | | service.loadBalancerIP | Appsmith service Load Balancer IP...

Near line 123: Possible spelling mistake found.
Context: ... | | service.loadBalancerIP | Appsmith service Load Balancer IP ...

Near line 123: Possible typo: you repeated a whitespace
Context: ...Load Balancer IP | "" | | `service.loadBalancerS...

Near line 124: Possible spelling mistake found.
Context: ... | "" | | service.loadBalancerSourceRanges | Appsmith service Load Balancer sourc...

Near line 124: Possible spelling mistake found.
Context: ... | service.loadBalancerSourceRanges | Appsmith service Load Balancer sources ...

Near line 124: Possible typo: you repeated a whitespace
Context: ...| Appsmith service Load Balancer sources | [] | | `service.annotation...

Near line 125: Possible typo: you repeated a whitespace
Context: ... | [] | | service.annotations | Additional custom annotations for...

Near line 125: Possible spelling mistake found.
Context: ... | Additional custom annotations for Appsmith service | {} ...

Near line 125: Possible typo: you repeated a whitespace
Context: ...ons for Appsmith service | {} | | ingress.enabled ...

Near line 126: Possible typo: you repeated a whitespace
Context: ... | {} | | ingress.enabled | Enable ingress record generation ...

Near line 126: Possible spelling mistake found.
Context: ... | Enable ingress record generation for Appsmith ...

Near line 126: Possible typo: you repeated a whitespace
Context: ...e ingress record generation for Appsmith | false | | ingress.annotations ...

Near line 128: Possible typo: you repeated a whitespace
Context: ... | {} | | ingress.hosts | An array of hosts to be covered w...

Near line 128: Possible typo: you repeated a whitespace
Context: ...ts to be covered with the ingress record | [] | | ingress.tls ...

Near line 129: Possible spelling mistake found.
Context: ... | [] | | ingress.tls | Enable TLS configu...

Near line 129: Possible typo: you repeated a whitespace
Context: ... | [] | | ingress.tls | Enable TLS configuration for the ...

Near line 129: Possible typo: you repeated a whitespace
Context: ...sts defined at ingress.hosts parameter | false | | ingress.secrets ...

Near line 131: Possible spelling mistake found.
Context: ... | [] | | ingress.certManager | Enable ingress to use TLS cer...

Near line 132: Possible spelling mistake found.
Context: ...ert Manager | false | | ingress.certManagerTls | Specify TLS secret resources cr...

Near line 133: Possible spelling mistake found.
Context: ... Manager | [] | | ingress.className | Configure Ingress class t...

Near line 133: Possible typo: you repeated a whitespace
Context: ... | [] | | ingress.className | Configure Ingress class that being use...

Near line 136: Possible typo: you repeated a whitespace
Context: ...Persistence parameters | Name | Description ...

Near line 139: Possible spelling mistake found.
Context: ...ume Claims | true | | persistence.storageClass | Persistent Volume storage class ...

Near line 140: Possible typo: you repeated a whitespace
Context: ... | | persistence.annotations | Additional custom annotations for the ...

Near line 141: Possible spelling mistake found.
Context: ...the PVC | {} | | persistence.localStorage | Enable persistent volume using l...

Near line 142: Possible spelling mistake found.
Context: ...storage | false | | persistence.storagePath | Local storage path ...

Near line 142: Possible spelling mistake found.
Context: ...storage path | /tmp/hostpath_pv | | persistence.localCluster ...

Near line 143: Possible spelling mistake found.
Context: ... | /tmp/hostpath_pv | | persistence.localCluster | Local running cluster to provide...

Near line 143: Possible spelling mistake found.
Context: ...r to provide storage space | [minikube] | | persistence.accessModes ...

Near line 144: Possible spelling mistake found.
Context: ...space | [minikube] | | persistence.accessModes | Persistent Volume access modes ...

Near line 144: Possible spelling mistake found.
Context: ...olume access modes | [ReadWriteOnce] | | persistence.size | Per...

Near line 146: Possible spelling mistake found.
Context: ... | 10Gi | | storageClass.enabled | Enable Storage Class c...

Near line 147: Possible spelling mistake found.
Context: ...on | false | | storageClass.defaultClass | Create default Stor...

Near line 148: Possible spelling mistake found.
Context: ... | false | | storageClass.bindingMode | Binding mode for Per...

Near line 149: Possible spelling mistake found.
Context: ...Storage Class | Immediate | | storageClass.allowVolumeExpansion | Allow expansion...

Near line 150: Possible spelling mistake found.
Context: ...ing Storage Class | true | | storageClass.reclaimPolicy | Configure the reten...

Near line 151: Possible spelling mistake found.
Context: ...d Persistent Volume | Delete | | storageClass.provisioner | Storage Class provis...

Near line 152: Possible spelling mistake found.
Context: ... | "" | | storageClass.annotations | Additional storage c...

Near line 153: Possible spelling mistake found.
Context: ...tions | {} | | storageClass.mountOptions | Mount options used ...

Near line 154: Possible spelling mistake found.
Context: ...Volumes | {} | | storageClass.parameters | Storage Class parame...

Near line 156: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’).
Context: ... | {} | ### Auto update chart's image | Name | Descrip...

Near line 159: Possible spelling mistake found.
Context: ...------------------- | ------------- | | autoupdate.enabled | Enable auto update Helm cha...

Near line 159: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’).
Context: ...---- | | autoupdate.enabled | Enable auto update Helm chart's image | true | | ...

Near line 160: Possible spelling mistake found.
Context: ... Helm chart's image | true | | autoupdate.scheduler | Schedule time to run cron ...

Near line 162: Put a space after the comma.
Context: ...* * *" | Specify each parameter using --set key=value[,key=value]` argument to helm install. For e...

Near line 175: Unpaired symbol: ‘]’ seems to be missing
Context: ...name ``` *Tip: You can use the default [values.yaml](https://github.com/appsmith...

Near line 177: Possible spelling mistake found.
Context: .../release/deploy/helm/values.yaml)* ### Appsmith configuration To change Appsmith config...

Near line 178: Possible spelling mistake found.
Context: ...* ### Appsmith configuration To change Appsmith configurations, you can use configurati...

Near line 181: Possible spelling mistake found.
Context: ...---------- | --------------------- | | applicationConfig.APPSMITH_OAUTH2_GOOGLE_CLIENT_ID | `"...

Near line 182: Possible spelling mistake found.
Context: ...2_GOOGLE_CLIENT_ID | "" | | applicationConfig.APPSMITH_OAUTH2_GOOGLE_CLIENT_SECRET`| ...

Near line 183: Possible spelling mistake found.
Context: ...GOOGLE_CLIENT_SECRET| "" | | applicationConfig.APPSMITH_OAUTH2_GITHUB_CLIENT_ID | "...

Near line 184: Possible spelling mistake found.
Context: ...2_GITHUB_CLIENT_ID | "" | | applicationConfig.APPSMITH_OAUTH2_GITHUB_CLIENT_SECRET`| ...

Near line 185: Possible spelling mistake found.
Context: ...GITHUB_CLIENT_SECRET| "" | | applicationConfig.APPSMITH_CLIENT_LOG_LEVEL | ""` ...

Near line 186: Possible spelling mistake found.
Context: ...IENT_LOG_LEVEL | "" | | applicationConfig.APPSMITH_MAIL_ENABLED | ""` ...

Near line 187: Possible spelling mistake found.
Context: ...MAIL_ENABLED | "" | | applicationConfig.APPSMITH_MAIL_HOST | ""` ...

Near line 188: Possible spelling mistake found.
Context: ...H_MAIL_HOST | "" | | applicationConfig.APPSMITH_MAIL_PORT | ""` ...

Near line 189: Possible spelling mistake found.
Context: ...H_MAIL_PORT | "" | | applicationConfig.APPSMITH_MAIL_USERNAME | ""` ...

Near line 190: Possible spelling mistake found.
Context: ...MAIL_USERNAME | "" | | applicationConfig.APPSMITH_MAIL_PASSWORD | ""` ...

Near line 191: Possible spelling mistake found.
Context: ...MAIL_PASSWORD | "" | | applicationConfig.APPSMITH_MAIL_FROM | ""` ...

Near line 192: Possible spelling mistake found.
Context: ...H_MAIL_FROM | "" | | applicationConfig.APPSMITH_REPLY_TO | ""` ...

Near line 193: Possible spelling mistake found.
Context: ...H_REPLY_TO | "" | | applicationConfig.APPSMITH_MAIL_SMTP_AUTH | ""` ...

Near line 194: Possible spelling mistake found.
Context: ...AIL_SMTP_AUTH | "" | | applicationConfig.APPSMITH_MAIL_SMTP_TLS_ENABLED | ""...

Near line 195: Possible spelling mistake found.
Context: ..._SMTP_TLS_ENABLED | "" | | applicationConfig.APPSMITH_DISABLE_TELEMETRY | ""` ...

Near line 196: Possible spelling mistake found.
Context: ...SABLE_TELEMETRY | "" | | applicationConfig.APPSMITH_RECAPTCHA_SITE_KEY | ""`...

Near line 197: Possible spelling mistake found.
Context: ...APTCHA_SITE_KEY | "" | | applicationConfig.APPSMITH_RECAPTCHA_SECRET_KEY | ""...

Near line 198: Possible spelling mistake found.
Context: ...PTCHA_SECRET_KEY | "" | | applicationConfig.APPSMITH_RECAPTCHA_ENABLED | ""` ...

Near line 199: Possible spelling mistake found.
Context: ...CAPTCHA_ENABLED | "" | | applicationConfig.APPSMITH_MONGODB_URI | ""` ...

Near line 200: Possible spelling mistake found.
Context: ..._MONGODB_URI | "" | | applicationConfig.APPSMITH_REDIS_URL | ""` ...

Near line 201: Possible spelling mistake found.
Context: ...H_REDIS_URL | "" | | applicationConfig.APPSMITH_ENCRYPTION_PASSWORD | ""`...

Near line 202: Possible spelling mistake found.
Context: ...RYPTION_PASSWORD | "" | | applicationConfig.APPSMITH_ENCRYPTION_SALT | ""` ...

Near line 203: Possible spelling mistake found.
Context: ...NCRYPTION_SALT | "" | | applicationConfig.APPSMITH_CUSTOM_DOMAIN | ""` ...

Near line 204: Possible spelling mistake found.
Context: ...CUSTOM_DOMAIN | "" | | applicationConfig.APPSMITH_FORM_LOGIN_DISABLED` | ...

Near line 204: Possible typo: you repeated a whitespace
Context: ...tionConfig.APPSMITH_FORM_LOGIN_DISABLED |"" | |application...

Near line 204: Possible typo: you repeated a whitespace
Context: ...SMITH_FORM_LOGIN_DISABLED |"" | |applicationConfig.APPSMITH_SIGNUP_D...

Near line 205: Possible spelling mistake found.
Context: ...LED |"" | |applicationConfig.APPSMITH_SIGNUP_DISABLED` | ...

Near line 205: Possible typo: you repeated a whitespace
Context: ...licationConfig.APPSMITH_SIGNUP_DISABLED |""` | For example, ...

Near line 205: Possible typo: you repeated a whitespace
Context: ...SMITH_SIGNUP_DISABLED |""` | For example, to change the encryption...

Near line 214: Possible spelling mistake found.
Context: ...appsmith --generate-name ``` ## Expose Appsmith - If you wish to publish your Appsmith ...

Near line 215: The verb ‘set up’ is spelled as two words. The noun ‘setup’ is spelled as one.
Context: ... through the Internet, you will need to setup the Ingress controller firstly. Please ...

Near line 215: Unpaired symbol: ‘]’ seems to be missing
Context: ...netes NGINX Ingress Controller** in the [Prerequisites](https://github.com/appsmi...

Near line 216: The inflection of the verb “install” seems to be incorrect here.
Context: ...rerequisites) - In case of you have not install the Helm chart yet, you can run the bel...

Near line 223: Possible spelling mistake found.
Context: ...e=ClusterIP ``` - If you have installed Appsmith Helm chart, please run the `helm upgrad...

Additional comments not posted (6)

deploy/helm/templates/statefulset.yaml (4)

52-52: Ensure the image reference for the Redis init container is dynamically constructed from the Helm values.

55-55: Verify that the imagePullPolicy for the Redis init container is correctly set from the Helm values.

62-62: Ensure the image reference for the MongoDB init container is dynamically constructed from the Helm values.

65-65: Verify that the imagePullPolicy for the MongoDB init container is correctly set from the Helm values.

deploy/helm/values.yaml (1)

67-77: The initContainer section for Redis and MongoDB has been correctly structured to include registry, repository, tag, and pull policy. This aligns with the PR's objectives to enhance flexibility for users with custom registries.

deploy/helm/README.md (1)

84-91: Ensure consistency in the documentation format for the new initContainer parameters.

Consider aligning the format of the new initContainer parameters with the existing parameters in the document. This includes consistent use of capitalization, descriptions, and alignment in the table.

Warning

Following problems were encountered

Git: Failed to clone repository. Please contact CodeRabbit support.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-04-29T16:34:50Z

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

kvandenhoute · 2024-05-02T06:10:15Z

keep open

github-actions · 2024-05-09T16:36:55Z

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

kvandenhoute · 2024-05-14T08:04:01Z

@sharat87 @pratapaprasanna Possible to have a look at this? Anything you want me to change?

github-actions · 2024-05-22T16:36:26Z

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

kvandenhoute · 2024-05-22T16:44:16Z

@sharat87 @pratapaprasanna Possible to have a look at this? Anything you want me to change?

github-actions · 2024-06-04T16:36:48Z

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

kvandenhoute · 2024-09-04T13:15:36Z

bump

Configurable init container images

e963b89

kvandenhoute requested review from pratapaprasanna and sharat87 as code owners April 22, 2024 09:26

kvandenhoute changed the title ~~Configurable init container images~~ [improve] [deploy] Configurable init container images Apr 22, 2024

github-actions bot added the Stale label Apr 29, 2024

github-actions bot removed the Stale label May 2, 2024

github-actions bot added the Stale label May 9, 2024

github-actions bot removed the Stale label May 14, 2024

github-actions bot added the Stale label May 22, 2024

kvandenhoute changed the title ~~[improve] [deploy] Configurable init container images~~ improve: Configurable init container images May 24, 2024

kvandenhoute changed the title ~~improve: Configurable init container images~~ feat: Configurable init container images May 24, 2024

github-actions bot removed the Stale label May 27, 2024

github-actions bot added the Stale label Jun 4, 2024

Conversation

kvandenhoute commented Apr 22, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Communication

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Following problems were encountered

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Apr 29, 2024

Uh oh!

kvandenhoute commented May 2, 2024

Uh oh!

github-actions bot commented May 9, 2024

Uh oh!

kvandenhoute commented May 14, 2024

Uh oh!

github-actions bot commented May 22, 2024

Uh oh!

kvandenhoute commented May 22, 2024

Uh oh!

github-actions bot commented Jun 4, 2024

Uh oh!

kvandenhoute commented Sep 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kvandenhoute commented Apr 22, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 22, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)