Skip to content

fix: Fix for using charset from response headers instead of default UTF-8#20862

Open
balachandarsv wants to merge 4 commits intoappsmithorg:releasefrom
balachandarsv:release
Open

fix: Fix for using charset from response headers instead of default UTF-8#20862
balachandarsv wants to merge 4 commits intoappsmithorg:releasefrom
balachandarsv:release

Conversation

@balachandarsv
Copy link

@balachandarsv balachandarsv commented Feb 22, 2023

Description

The REST-API response content are by default parsed in UTF-8 irrespective of what the response content-type header charset is sent.

Fixes #

Checks for any charset mentioned in response headers, if mentioned, it used the charset otherwise defaults to UTF-8

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

@welcome
Copy link

welcome bot commented Feb 22, 2023

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.

@vercel
Copy link

vercel bot commented Feb 22, 2023

@balachandarsv is attempting to deploy a commit to the Appsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This PR has been closed because of inactivity.

@github-actions github-actions bot closed this Mar 9, 2023
@mohanarpit mohanarpit reopened this Mar 29, 2023
@mohanarpit mohanarpit changed the title Fix for using charset from response headers instead of default UTF-8 fix: Fix for using charset from response headers instead of default UTF-8 Mar 29, 2023
@mohanarpit mohanarpit requested a review from sumitsum March 29, 2023 20:18
@mohanarpit
Copy link
Member

mohanarpit commented Mar 29, 2023

@balachandarsv Thank you for opening this PR. Apologies that it slipped through the cracks. I've reopened the PR and we'll work to merge this in. In the meantime, can I request you to please open a Github issue for this?

sumitsum
sumitsum suggested changes Apr 4, 2023
View reviewed changes
...s/src/main/java/com/appsmith/external/helpers/restApiUtils/helpers/RestAPIActivateUtils.java
if (contentType.includes(MediaType.APPLICATION_JSON)) {
try {
String jsonBody = new String(body, StandardCharsets.UTF_8);
Charset charset = contentType.getCharset();
Copy link
Contributor

@sumitsum sumitsum Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a JUnit TC for this in the file RestApiPluginTest.java ?

Copy link
Author

@balachandarsv balachandarsv Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Will do.

Copy link
Contributor

@sumitsum sumitsum Apr 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balachandarsv please mention here once you are done.

Copy link
Author

@balachandarsv balachandarsv May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check @sumitsum

@balachandarsv balachandarsv mentioned this pull request Apr 4, 2023
Closed
1 task
@sumitsum sumitsum added the Community Contributor Meant to track issues that are assigned to external contributors label May 5, 2023
@sumitsum
Copy link
Contributor

sumitsum commented May 10, 2023

Hi @balachandarsv , please mention if you are still working on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sumitsum sumitsum sumitsum requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@balachandarsv balachandarsv

Labels

Community Contributor Meant to track issues that are assigned to external contributors Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@balachandarsv @mohanarpit @sumitsum