chore: List widget UI property pane test cases by laveena-en · Pull Request #19532 · appsmithorg/appsmith

laveena-en · 2023-01-06T09:00:12Z

Description

Added cypress tests to validate properties for the list widget on the property pane under Content.

Type of change

Cypress automation test-cases.

How Has This Been Tested?

Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Test plan has been approved by relevant developers
Test plan has been peer reviewed by QA
Cypress test cases have been added and approved by either SDET or manual QA
Organized project review call with relevant stakeholders after Round 1/2 of QA
Added Test Plan Approved label after reveiwing all Cypress test

welcome · 2023-01-06T09:00:15Z

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.

vercel · 2023-01-06T09:00:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 5, 2023 at 3:51PM (UTC)

Aishwarya-U-R · 2023-01-06T09:04:11Z

Test Plan Approved to be added once review complete & approval received from your reviewer.

laveena-en · 2023-01-06T09:06:08Z

/ok-to-test sha=b8597a0

github-actions · 2023-01-06T09:06:36Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3854010578.
Workflow: Appsmith External Integration Test Workflow.
Commit: b8597a0.
PR: 19532.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19532&runId=3854010578_1

github-actions · 2023-01-06T10:07:55Z

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts

github-actions · 2023-01-06T10:07:55Z

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite_Fat/ClientSideTests/Refactoring/Refactoring_spec.ts

github-actions · 2023-01-09T06:40:15Z

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts

laveena-en · 2023-01-09T07:01:02Z

/ok-to-test sha=ee99793

github-actions · 2023-01-09T07:01:26Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3871474544.
Workflow: Appsmith External Integration Test Workflow.
Commit: ee99793.
PR: 19532.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19532&runId=3871474544_1

app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts

github-actions · 2023-01-09T08:28:23Z

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts

github-actions · 2023-01-16T16:38:52Z

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

Signed-off-by: Laveena Enid <laveena@appsmith.com>

laveena-en · 2023-01-20T08:17:59Z

/ok-to-test sha=a0ded80

github-actions · 2023-01-20T08:18:26Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3965884582.
Workflow: Appsmith External Integration Test Workflow.
Commit: a0ded80.
PR: 19532.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19532&runId=3965884582_1

github-actions · 2023-01-20T09:43:55Z

The following are new failures, please fix them before merging the PR

cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts

github-actions · 2023-01-20T13:30:16Z

The following are new failures, please fix them before merging the PR

cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts

github-actions · 2023-01-20T15:27:07Z

The following are new failures, please fix them before merging the PR

cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts

Aishwarya-U-R · 2023-01-23T04:31:43Z

app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts

+  it("1. Validate if the 'items', 'server-side pagination', 'Visible', 'Animate Loading' and 'OnListItemClick' properties are present in the property pane", () => {
+    _.ee.SelectEntityByName("List1", "Widgets");
+    _.agHelper.AssertElementVisible(_.locators._listWidgetItemsDatalabel);
+    _.agHelper.AssertElementVisible(_.locators._listWidgetPaginationlabel);


Can you try - _.agHelper.AssertContains('Visible', 'exists', 'label') & if this works - remove the locators defined.

Mentioned utility worked, refactored it. Resolved in 54dacc4.

Aishwarya-U-R · 2023-01-23T04:32:18Z

app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts

+    _.agHelper.AssertElementVisible(_.locators._listWidgetVisiblelabel);
+    _.agHelper.AssertElementVisible(_.locators._listWidgetAnimateLoadinglabel);
+    _.agHelper.AssertElementVisible(_.locators._listWidgetClickEventlabel);
+  });


Only one ''it' function. Is that all?

The PR was for adding basic test cases for testing property pane, these statements were consolidated into a single 'it' function as per the review comment https://github.com/appsmithorg/appsmith/pull/19532/files/b8597a0caddafb18248e9828e9b4f02da0a5db19#r1063383684

Signed-off-by: Laveena Enid <laveena@appsmith.com>

laveena-en · 2023-02-05T15:50:50Z

/ok-to-test sha=54dacc4

github-actions · 2023-02-05T15:51:18Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4097341680.
Workflow: Appsmith External Integration Test Workflow.
Commit: 54dacc4.
PR: 19532.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19532&runId=4097341680_1

github-actions · 2023-02-05T16:56:50Z

The following are new failures, please fix them before merging the PR

github-actions · 2023-02-05T16:56:52Z

The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts

github-actions · 2023-02-06T05:16:27Z

The following are new failures, please fix them before merging the PR

github-actions · 2023-02-06T05:16:28Z

The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts

Aishwarya-U-R · 2023-02-07T06:06:25Z

...client/cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts

+    _.agHelper.AssertContains("Server Side Pagination", "exist", "label");
+    _.agHelper.AssertContains("Visible", "exist", "label");
+    _.agHelper.AssertContains("Animate Loading", "exist", "label");
+    _.agHelper.AssertContains("onListItemClick", "exist", "label");


Add few more validations into the spec & then this can be run & merged.
The written case looks ok.

List widget UI property pane test cases

b8597a0

laveena-en requested review from Aishwarya-U-R and Vijetha-Kaja January 6, 2023 09:00

laveena-en added List Widget Issues related to the list widget Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable labels Jan 6, 2023

Aishwarya-U-R removed the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Jan 6, 2023

vercel bot deployed to Preview January 6, 2023 09:05 View deployment

laveena-en changed the title ~~List widget UI property pane test cases~~ chore: List widget UI property pane test cases Jan 6, 2023

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jan 6, 2023

laveena-en force-pushed the listwidget-ui branch from 85c48ba to b8597a0 Compare January 9, 2023 06:52

List widget UI property pane test cases

ee99793

Vijetha-Kaja reviewed Jan 9, 2023

View reviewed changes

app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview January 9, 2023 07:12 View deployment

Vijetha-Kaja reviewed Jan 9, 2023

View reviewed changes

app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/List/List_v1_Spec.ts Outdated Show resolved Hide resolved

List widget UI property pane test cases

c953606

vercel bot deployed to Preview January 9, 2023 08:28 View deployment

github-actions bot added the Stale label Jan 16, 2023

List widget UI property pane test cases - Resolved review comments.

c4c6f2e

Signed-off-by: Laveena Enid <laveena@appsmith.com>

Merge branch 'release' into listwidget-ui

a0ded80

laveena-en requested a review from Vijetha-Kaja January 20, 2023 08:16

vercel bot had a problem deploying to Preview January 20, 2023 08:24 Failure

github-actions bot removed the Stale label Jan 20, 2023

Aishwarya-U-R reviewed Jan 23, 2023

View reviewed changes

laveena-en added 3 commits February 5, 2023 20:50

List widget UI property pane test cases - Resolved review comments.

48d5629

Signed-off-by: Laveena Enid <laveena@appsmith.com>

Merge branch 'release' into listwidget-ui

ab2fd57

List widget UI property pane test cases - Resolved review comments.

54dacc4

Signed-off-by: Laveena Enid <laveena@appsmith.com>

vercel bot deployed to Preview February 5, 2023 15:51 View deployment

laveena-en requested a review from Aishwarya-U-R February 7, 2023 06:04

Aishwarya-U-R reviewed Feb 7, 2023

View reviewed changes

Conversation

laveena-en commented Jan 6, 2023

Description

Type of change

How Has This Been Tested?

Test Plan

Checklist:

Dev activity

QA activity:

Uh oh!

welcome bot commented Jan 6, 2023

Uh oh!

vercel bot commented Jan 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aishwarya-U-R commented Jan 6, 2023

Uh oh!

laveena-en commented Jan 6, 2023

Uh oh!

github-actions bot commented Jan 6, 2023

Uh oh!

github-actions bot commented Jan 6, 2023

Uh oh!

github-actions bot commented Jan 6, 2023

Uh oh!

github-actions bot commented Jan 9, 2023

Uh oh!

laveena-en commented Jan 9, 2023

Uh oh!

github-actions bot commented Jan 9, 2023

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 9, 2023

Uh oh!

github-actions bot commented Jan 16, 2023

Uh oh!

laveena-en commented Jan 20, 2023

Uh oh!

github-actions bot commented Jan 20, 2023

Uh oh!

github-actions bot commented Jan 20, 2023

Uh oh!

github-actions bot commented Jan 20, 2023

Uh oh!

github-actions bot commented Jan 20, 2023

Uh oh!

Aishwarya-U-R Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

laveena-en Feb 5, 2023

Choose a reason for hiding this comment

Uh oh!

Aishwarya-U-R Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

laveena-en Feb 5, 2023

Choose a reason for hiding this comment

Uh oh!

laveena-en commented Feb 5, 2023

Uh oh!

github-actions bot commented Feb 5, 2023

Uh oh!

github-actions bot commented Feb 5, 2023

Uh oh!

github-actions bot commented Feb 5, 2023

Uh oh!

github-actions bot commented Feb 6, 2023

Uh oh!

github-actions bot commented Feb 6, 2023

Uh oh!

Aishwarya-U-R Feb 7, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

vercel bot commented Jan 6, 2023 •

edited

Loading