Add debug util for gateway #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnobKumarSaha
force-pushed
the
gw
branch
8 times, most recently
from
c93057f to
e3e76f0
Compare
ArnobKumarSaha
force-pushed
the
gw
branch
9 times, most recently
from
23ad93c to
5f693ef
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new debug utility for gateway components to the CLI tool. The debug command provides comprehensive collection of gateway-related Kubernetes resources, logs, and configurations for troubleshooting purposes.
Key changes:
- Adds a new
debugcommand with gateway subcommand functionality - Implements collection of gateway resources (gateways, routes, secrets, certificates, etc.)
- Includes log collection from gateway operators and envoy proxies
- Updates Go version and adds required dependencies for gateway APIs
Reviewed Changes
Copilot reviewed 12 out of 5266 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/cmds/root.go | Adds debug command and comments out cloud_swap command |
| pkg/cmds/debug/debug.go | Main debug command entry point |
| pkg/cmds/debug/gateway/gateway.go | Core gateway debug functionality and command setup |
| pkg/cmds/debug/gateway/yamls_gw.go | Gateway resource collection (gateways, classes, envoy proxy) |
| pkg/cmds/debug/gateway/yamls.go | Additional resource collection (helm releases, secrets, services) |
| pkg/cmds/debug/gateway/routes.go | Route resource collection with parent reference filtering |
| pkg/cmds/debug/gateway/logs.go | Log collection from operator and gateway pods |
| pkg/cmds/debug/gateway/helpers.go | Utility functions for YAML writing and resource mapping |
| pkg/cmds/debug/gateway/config_dump.go | Envoy configuration dump collection via port forwarding |
| pkg/cmds/debug/gateway/cert.go | Certificate-related resource collection |
| pkg/cmds/debug/gateway/binding.go | Database binding resource collection |
| go.mod | Updates Go version and adds gateway API dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| func (g *gatewayOpts) getKindFromResource(res string) string { | ||
| kind, exists := g.resMap[res] | ||
| if !exists { | ||
| _ = fmt.Errorf("resource %s not supported", res) |
There was a problem hiding this comment.
Error is created but discarded with underscore assignment. This should either return the error or log it for debugging purposes.
ArnobKumarSaha
force-pushed
the
gw
branch
3 times, most recently
from
23e7fdd to
0d07eab
Compare
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.