Skip to content

Please review the library , all the mentioned reviews have been resolved#3

Open
Ajith6901 wants to merge 37 commits into
applibgroup:mainfrom
Ajith6901:main
Open

Please review the library , all the mentioned reviews have been resolved#3
Ajith6901 wants to merge 37 commits into
applibgroup:mainfrom
Ajith6901:main

Conversation

@Ajith6901

Copy link
Copy Markdown

No description provided.

@CLAassistant

CLAassistant commented May 4, 2022

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Ajith6901
✅ Gleelakrishna
❌ sasirekha111
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment thread README.md Outdated
# SmartBikeDesign


UI library created using hml , CSS and JS for **HarmonyOS Project**

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change string HarmonyOS to OpenHarmony

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please take ReadMe content from Vishnu

@@ -0,0 +1,16 @@
package com.example.smartbikedesign;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add copyright details in all new JS and Java files

Comment thread entry/build.gradle Outdated
ohosTestImplementation 'com.huawei.ohos.testkit:runner:1.0.0.100'
}
decc {
supportType = ['html','xml']

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove node_modules folder inside entry

@@ -0,0 +1,9 @@
{
"strings": {
"hello": "Hello",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the unused strings

@@ -0,0 +1,11 @@
[

{ "speedValue":"56",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format all the code file
Open file and do Ctrl + Alt + L to format

}else{
this.menu="/common/images/bottom/menu.png";

// console.info('Inside else condition of lowbeamonclick()');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the commented code

@@ -0,0 +1,8 @@
{
"strings": {
"hello": "您好",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused strings

@archanaatr archanaatr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check the comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants