Reexport HTTPTypes and AsyncStreaming from HTTPAPIs#130
Merged
Conversation
guoye-zhang
approved these changes
Mar 10, 2026
Contributor
|
We can remove the imports of |
Contributor
Author
|
Yeah I wasn't sure what to do from a "style" perspective: do we prefer to keep all used modules included in the files that use them? |
Contributor
|
It's hard to enforce since the compiler builds with or without the imports, so new files will likely miss them. Personally I would just remove them to be consistent. |
Contributor
Author
|
That's a fair argument - I've removed them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We should reexport
HTTPTypesandAsyncStreamingso that users importingHTTPAPIsdon't have to also import those modules.Modifications
Add an
Exportsfile with@_exported imports forHTTPTypesandAsyncStreaming.