Skip to content

Refactor URLSessionHTTPClient out of HTTPClient#127

Open
guoye-zhang wants to merge 3 commits intoapple:mainfrom
guoye-zhang:urlsession-client
Open

Refactor URLSessionHTTPClient out of HTTPClient#127
guoye-zhang wants to merge 3 commits intoapple:mainfrom
guoye-zhang:urlsession-client

Conversation

@guoye-zhang
Copy link
Contributor

@guoye-zhang guoye-zhang commented Mar 7, 2026

Several changes in this PR:

  1. Refactored URLSessionHTTPClient into its own target
  2. URLSessionHTTPClient, URLSessionRequestOptions, and URLSessionConnectionPoolConfiguration are now public types
  3. Renamed AsyncHTTPClientConformance into AHCHTTPClient since it sounds too similar to HTTPClientConformance which is a test suite
  4. DefaultHTTPClient is now backed by AHC on Linux

@guoye-zhang guoye-zhang added the ⚠️ semver/major Breaks existing public API. label Mar 7, 2026
@guoye-zhang
Copy link
Contributor Author

guoye-zhang commented Mar 7, 2026

The Linux test failure appears to be a preexisting issue on main:

✘ Test conformance() recorded an issue at HTTPClientConformance.swift:97:33: Caught error: I/O on closed channel
↳ .test304WithContentLength

@fabianfett @xbhatnag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FranzBusch FranzBusch Awaiting requested review from FranzBusch

@nakulbajaj nakulbajaj Awaiting requested review from nakulbajaj

@fabianfett fabianfett Awaiting requested review from fabianfett

@xbhatnag xbhatnag Awaiting requested review from xbhatnag

@travarin travarin Awaiting requested review from travarin

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

⚠️ semver/major Breaks existing public API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@guoye-zhang