Open
Conversation
Changed collapsed module nodes background color from gray to white to improve visibility and consistency across all examples and loaders. - Updated ONNX loader module nodes - Updated DOT loader module nodes - Updated landing page example - Updated simple example - Updated getting-started documentation - Added gray foreground colors to module text for better contrast
Member
|
Could you make a before and after image? |
Author
Member
|
It looks fine for me at https://apple.github.io/ml-mycelium/. Do you have a different version?
|
Author
|
When I open this address, https://apple.github.io/ml-mycelium/getting-started, it appears black to me. |
Member
|
Odd. Do you know why https://apple.github.io/ml-mycelium/ works but https://apple.github.io/ml-mycelium/getting-started is broken? |
Author
|
Unfortunately, I have no idea. |
Member
Author
|
Yes Dominik Moritz, it seems like that's the source of the problem. |
Member
|
Could you check why it's different and just make the minimal change to fix it? |
Author
|
Okay, I'll look into it and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Summary
Changed collapsed module nodes background color from gray to white to improve visibility and consistency.

Changes
Theme.colors.background.graytoTheme.colors.whitein all examples and loaderssrc/lib/loader/onnx/index.ts,src/lib/loader/onnx/view/node.ts)src/lib/loader/dot.ts)src/routes/(landing)/+page.svelte)src/routes/(app)/example/simple/+page.svelte)src/routes/(landing)/getting-started/landing.mdx)Testing
Tested with collapse all functionality - collapsed modules now display with white background instead of appearing black.
By submitting this pull request, I represent that I have the right to license this contribution to Apple and the community, and agree that my contributions are licensed under the project's LICENSE.