Skip to content

Fix collapsed module background color#3

Open
ymzEmre wants to merge 1 commit intoapple:mainfrom
ymzEmre:fix/collapsed-module-background
Open

Fix collapsed module background color#3
ymzEmre wants to merge 1 commit intoapple:mainfrom
ymzEmre:fix/collapsed-module-background

Conversation

@ymzEmre
Copy link
Copy Markdown

@ymzEmre ymzEmre commented Dec 13, 2025

Summary

Changed collapsed module nodes background color from gray to white to improve visibility and consistency.
Screenshot 2025-12-14 at 00 13 13

Changes

  • Updated module background color from Theme.colors.background.gray to Theme.colors.white in all examples and loaders
  • Added gray foreground colors to module text elements for better contrast
  • Applied changes to:
    • ONNX loader (src/lib/loader/onnx/index.ts, src/lib/loader/onnx/view/node.ts)
    • DOT loader (src/lib/loader/dot.ts)
    • Landing page example (src/routes/(landing)/+page.svelte)
    • Simple example (src/routes/(app)/example/simple/+page.svelte)
    • Getting started documentation (src/routes/(landing)/getting-started/landing.mdx)

Testing

Tested with collapse all functionality - collapsed modules now display with white background instead of appearing black.

By submitting this pull request, I represent that I have the right to license this contribution to Apple and the community, and agree that my contributions are licensed under the project's LICENSE.

Changed collapsed module nodes background color from gray to white
to improve visibility and consistency across all examples and loaders.

- Updated ONNX loader module nodes
- Updated DOT loader module nodes
- Updated landing page example
- Updated simple example
- Updated getting-started documentation
- Added gray foreground colors to module text for better contrast
@domoritz
Copy link
Copy Markdown
Member

Could you make a before and after image?

@ymzEmre
Copy link
Copy Markdown
Author

ymzEmre commented Dec 15, 2025

Before, the background appears black, as shown in the image above. After, I added the image, and the fixed version shows a white background.
Screenshot 2025-12-15 at 23 07 31

@domoritz
Copy link
Copy Markdown
Member

It looks fine for me at https://apple.github.io/ml-mycelium/. Do you have a different version?

Screenshot 2025-12-16 at 09 57 20

@ymzEmre
Copy link
Copy Markdown
Author

ymzEmre commented Dec 17, 2025

When I open this address, https://apple.github.io/ml-mycelium/getting-started, it appears black to me.
Screenshot 2025-12-17 at 17 07 18

@domoritz
Copy link
Copy Markdown
Member

Odd. Do you know why https://apple.github.io/ml-mycelium/ works but https://apple.github.io/ml-mycelium/getting-started is broken?

@ymzEmre
Copy link
Copy Markdown
Author

ymzEmre commented Dec 17, 2025

Unfortunately, I have no idea.

@domoritz
Copy link
Copy Markdown
Member

Looks like the good one has a fill

Screenshot 2025-12-17 at 14 47 09 Screenshot 2025-12-17 at 14 47 14

@ymzEmre
Copy link
Copy Markdown
Author

ymzEmre commented Dec 17, 2025

Yes Dominik Moritz, it seems like that's the source of the problem.

@domoritz
Copy link
Copy Markdown
Member

Could you check why it's different and just make the minimal change to fix it?

@ymzEmre
Copy link
Copy Markdown
Author

ymzEmre commented Dec 18, 2025

Okay, I'll look into it and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants