Skip to content

Conversation

@iko1
Copy link
Contributor

@iko1 iko1 commented Jan 16, 2026

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

Fixes #1045
When stderr is redirected to a file, the debug warning includes raw ANSI escape codes.
I added a code that detects if the stderr is redirected to a file and then write plain text.

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

@jglogan
Copy link
Contributor

jglogan commented Jan 16, 2026

@iko1 thanks for the contribution!

It looks fine and should be good to merge once we get the ongoing integration test issue sorted out.

It the future, check the issue to see if someone is already assigned. In this case someone else had asked to work on it and I assigned them.

@jglogan
Copy link
Contributor

jglogan commented Jan 16, 2026

Could you rebase your PR to main to pick up the integration test fix? Thanks!

@iko1 iko1 force-pushed the fix/debug-perf-warn-with-ansi-codes-into-file branch from a83c01b to 75a5ac5 Compare January 16, 2026 22:18
@iko1
Copy link
Contributor Author

iko1 commented Jan 16, 2026

Could you rebase your PR to main to pick up the integration test fix? Thanks!

Done, Thanks for the review.
Understood on the assignment, next time I’ll pick up a more complex issue and make sure it’s unassigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: UX: Debug performance warning should not output ANSI codes if stderr redirected.

2 participants