Throw error when starting a container with invalid virtiofs source #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaewonHur
force-pushed
the
check-virtiofs-deleted
branch
from
2841247 to
b7f738d
Compare
jglogan
approved these changes
Jan 14, 2026
Contributor
|
Seeing this test failure: |
Contributor
Author
|
Previous failures may have affect the following ones. Below is the failing test cases in git action. Could we try testing again to check it reproduces the same? |
Run = Create + Start
1) Mount source points to a valid directory
- Run and Create + Start both correctly create the container with
mount.
2) Mount source points to a file
- Run fails bootstrapping the container, thus container not created.
- Create creates the container, but Start fails bootstrapping,
removing the container.
(Thus, both are the same.)
3) Mount source deleted or replaced to file after container created
- Start throw errors but do not delete the container.
JaewonHur
force-pushed
the
check-virtiofs-deleted
branch
from
b7f738d to
e840b77
Compare
Contributor
Author
|
Integration test succeeded on my Mac. |
dcantah
reviewed
Jan 15, 2026
Comment on lines
+73
to
+77
| for mount in container.configuration.mounts where mount.isVirtiofs { | ||
| if !FileManager.default.fileExists(atPath: mount.source) { | ||
| throw ContainerizationError(.invalidState, message: "path '\(mount.source)' is not a directory") | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Is it possible for us to do this in bootstrap in the API server instead?
Contributor
Author
There was a problem hiding this comment.
It could be, but it might be duplicated as ClientCreate and ClientRun checks the mount source also.
Current bootstrap implicitly does it as making VM throws an error due to the wrong mount source path.
The thing is then, the container is just removed forever due to the cleanup logic.
Contributor
Author
|
It seems RunCommand fails randomly due to the XPC timeout when creating the container, but API server actually created the container internally. Since the container is not cleaned up in the earlier test, image prune fails as alpine image is not dangling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run = Create + Start
Mount source points to a valid directory
Mount source points to a file
Mount source deleted or replaced to file after container created
Type of Change
Motivation and Context
User can encounter unexpected container removal when shared volume source is in wrong state.
Testing