Upgrades version of Orbax/TF/TFIO to support HNS atomic folder rename#1355
Closed
deepikarajani24 wants to merge 3 commits intoapple:mainfrom
Closed
Upgrades version of Orbax/TF/TFIO to support HNS atomic folder rename#1355deepikarajani24 wants to merge 3 commits intoapple:mainfrom
deepikarajani24 wants to merge 3 commits intoapple:mainfrom
Conversation
|
This pull request has been automatically marked as stale because it has been inactive for 60 days. It will be closed in 7 days if no further activity occurs. If you would like to continue working on this, please remove the |
|
This pull request was closed because it has been inactive for more than 7 days since being marked as stale. Please feel free to reopen it if you would like to continue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the TensorFlow and Orbax dependencies to support the new HNS-native
RenameFolderAPI.Changes
To leverage this feature for HNS buckets, you'd need to configure
ocp.CheckpointManagerOptionswithtodelete_full_path="_trash".max_to_keepis exceeded, old checkpoints are now atomically moved to a_trashsubdirectory instead of being deleted.Context & Motivation
RenameFolderAPI, allowing for recursive, atomic directory moves.todelete_full_pathoption inCheckpointManagerOptions. When enabled, Orbax delegates totf.io.gfile.renameto move old checkpoints to a trash directory rather than performing a slow, object-by-object deletion.Validation
Scale testing was conducted on Axlearn workloads using this configuration. Results confirmed that the rename operations were significantly faster than the previous deletion mechanism, reducing overhead during checkpoint rotation.
Configuration Snippet