Skip to content

Conversation

@ido-ran
Copy link

@ido-ran ido-ran commented Jul 22, 2013

The command accept all the required parameters to run.
When running inside CI env there is no console window so we use NullProgressBar to make sure we do not try to execute console command that is not allowed.
Extract the user login logic into AccessTokenHelper static class.

… environment.

The command accept all the required parameters to run.
When running inside CI env there is no console window so we use NullProgressBar to make sure we do not try to execute console command that is not allowed.
Extract the user login logic into AccessTokenHelper static class.
@runesoerensen
Copy link
Contributor

Sorry about the back and forth here - I think it's great that this works for you, but I'm not sure it should be merged into the main project (I initially meant that you could have this command in your own custom build). However if we can figure out a good solution I think it'd be great if we could support both use cases in the existing DeployAppCommand.

All the various solutions for detecting whether there's a console seems like a hack. I haven't been able to find a better one, but I wonder if the Environment.UserInteractive property could be of use in this scenario. I think it could become a pretty clean solution if it works with your CI environment (instead of the HasConsole method https://github.com/appharbor/appharbor-cli/pull/19/files#L8R14)

@ido-ran
Copy link
Author

ido-ran commented Sep 6, 2013

That ok, I agree it is better it have one command but remember that it means adding username and password parameters because I have to do the auth every time without reling on previous user actions.

Some CI servers created and destroy very quickly and you can't expect a user to manually connect to the before running the deploy command. 

Ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants