fix/ADFA-3705 make apksigner executable

[jomen-adfa]

make apksigner executable

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 64f69a8c-7deb-44fb-b863-a624528d324b

📥 Commits

Reviewing files that changed from the base of the PR and between d97edf7 and 1438fa0.

📒 Files selected for processing (1)

• app/src/main/java/com/itsaky/androidide/assets/BaseAssetsInstaller.kt

---

📝 Walkthrough

Release Notes

• Added apksigner to the list of Android build tool binaries that have their executable permissions set during asset installation. The postInstall method in BaseAssetsInstaller.kt now ensures that the apksigner binary is executable along with other build tools (aapt, aapt2, aidl, d8, dexdump, split-select, zipalign). This is necessary for the APK signing process used during the build, which references apksigner from the build-tools directory.

• No risks identified. This is a straightforward permission fix following the established pattern used for other build tools. The change aligns with prior work to ensure all required build binaries are executable after installation.

Walkthrough

The pull request adds apksigner to the array of Android build tool binaries in BaseAssetsInstaller.postInstall whose executable permissions are set during installation. This ensures the APK signing tool is properly marked as executable alongside other build tools.

Changes

Cohort / File(s)	Summary
Build Tools Setup app/src/main/java/com/itsaky/androidide/assets/BaseAssetsInstaller.kt	Added apksigner to the list of build tool binaries whose permissions are set to executable during asset installation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

• fix/ADFA-3705 make d8 executable #1182: Both PRs add additional build-tool binaries (apksigner vs. d8) to the same permission-setting mechanism in BaseAssetsInstaller.postInstall.
• ADFA-2778: ensure binaries in build-tools are executable after installation #916: Both PRs ensure build-tools binaries are marked as executable; the retrieved PR introduced the loop infrastructure and this PR extends the list to include apksigner.

Suggested reviewers

• davidschachterADFA

Poem

🐰 A signer arrives in the tool-kit so grand,
With executable bit, now firmly in hand,
APK shall be signed with trustworthy flair,
One line added with care—the build tools now pair! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: making apksigner executable in the build tools.
Description check	✅ Passed	The description directly relates to the changeset by stating the intent to make apksigner executable, matching the actual code modification.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ADFA-3705-apksigner

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}