ADFA-3491 | Update missing icons to Material Design#1174
ADFA-3491 | Update missing icons to Material Design#1174
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 17 minutes and 10 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR updates drawable resource definitions and icon references in action classes. Two action classes now use an outlined variant of the help icon drawable, while two vector drawables are redesigned with larger viewports and new geometric path definitions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
resources/src/main/res/drawable/ic_computer_vision.xml (1)
9-9: Remove redundant transparent stroke attributes.
android:strokeColor="#00000000"is repeated but not needed here. Dropping it trims XML noise and slightly reduces resource size.Also applies to: 13-13, 17-17, 21-21
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@resources/src/main/res/drawable/ic_computer_vision.xml` at line 9, Remove the redundant transparent stroke attributes in ic_computer_vision.xml by deleting the repeated android:strokeColor="#00000000" occurrences; locate the path/vector elements that include android:strokeColor="#00000000" and remove that attribute (leaving any necessary strokeWidth or fill attributes intact) to reduce XML noise and resource size.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@resources/src/main/res/drawable/ic_computer_vision.xml`:
- Around line 2-5: The icon file ic_computer_vision.xml currently uses
android:width="20dp" android:height="20dp" with a huge viewport
(viewportWidth="1596" viewportHeight="1602") and very dense pathData, which
causes excessive downscaling for toolbar rendering; replace or normalize it to a
standard Material-size vector by setting android:width="24dp"
android:height="24dp" and viewportWidth/viewportHeight to 24 (or scale the
existing pathData mathematically to a 24x24 viewport), or swap the path for the
canonical 24x24 Material "computer" / "vision" icon path; ensure the path tag's
android:pathData is updated to the scaled/material version so GenerateXMLAction
(toolbar rendering) receives a 24x24 vector.
- Line 8: The vector drawable uses hardcoded black fill colors on its <path>
elements; add theme-driven tinting by adding
android:tint="?attr/colorControlNormal" to the root <vector> element and update
each path's android:fillColor to a neutral value (e.g. `@android`:color/white) so
the icon color is controlled by the theme; apply this change to all four <path>
elements.
---
Nitpick comments:
In `@resources/src/main/res/drawable/ic_computer_vision.xml`:
- Line 9: Remove the redundant transparent stroke attributes in
ic_computer_vision.xml by deleting the repeated android:strokeColor="#00000000"
occurrences; locate the path/vector elements that include
android:strokeColor="#00000000" and remove that attribute (leaving any necessary
strokeWidth or fill attributes intact) to reduce XML noise and resource size.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d8b12529-0d51-4c64-910c-de4abf4e172f
⛔ Files ignored due to path filters (2)
resources/src/main/res/drawable/fat_pen.pngis excluded by!**/*.pngresources/src/main/res/drawable/ic_action_help.pngis excluded by!**/*.png
📒 Files selected for processing (4)
app/src/main/java/com/itsaky/androidide/actions/file/ShowTooltipAction.ktapp/src/main/java/com/itsaky/androidide/actions/filetree/HelpAction.ktresources/src/main/res/drawable/ic_clone_repo.xmlresources/src/main/res/drawable/ic_computer_vision.xml
Replaces old PNGs and updates vectors for consistent line weight and UI/UX.
jatezzz
force-pushed
the
refactor/ADFA-3491-update-material-icons
branch
from
2c25ecb to
c6cf66e
Compare
jatezzz
requested review from
a team,
Daniel-ADFA,
dara-abijo-adfa,
itsaky-adfa and
jomen-adfa
1 participant
Description
Updates the icons for recently added features to use standardized Material Design icons. This ensures all UI elements share a consistent line weight, color, and visual style. Raster images (
.png) were removed, and vector drawables (.xml) were updated or replaced with their Material counterparts (e.g., switching to outlined help icons and updating the clone repo and computer vision vectors).Details
Screen.Recording.2026-04-10.at.3.58.14.PM.mov
Ticket
ADFA-3491
Observation
Removed old
.pngassets in favor of XML vector drawables to improve app size, scaling, and maintainability.