Skip to content

Add defaults to api object creation. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
twinge wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add defaults to api object creation. #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
194 changes: 99 additions & 95 deletions server/api/api_object_create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,108 +32,112 @@ var ObjConst = require('./api_object_constants.js');
var hasPermission = function (req, res, next) {
// Verify the current viewer has permission to perform this action.

if (!AD.Defaults.authRequired) next();
else {
if (!AD.Defaults.authRequired) next();
else {

var objKey = req.aRAD.objKey;
var objKey = req.aRAD.objKey;

var permission = 'hris.'+objKey+'.create';
var viewer = AD.Viewer.currentViewer(req);
var permission = 'hris.'+objKey+'.create';
var viewer = AD.Viewer.currentViewer(req);

log(req, ' - hasPermission(): checking for : '+permission);
log(req, ' - hasPermission(): checking for : '+permission);

// if viewer has 'hris.person.findAll' action/permission
if (viewer.hasTask(permission)) {
// if viewer has 'hris.person.findAll' action/permission
if (viewer.hasTask(permission)) {

log(req, ' viewer has permission: '+permission);
next();
log(req, ' viewer has permission: '+permission);
next();

} else {
} else {

errorDump(req, ' viewer failed permission check!');
ErrorMSG(req, res, 'ERR_NO_PERMISSION', AD.Const.HTTP.ERROR_FORBIDDEN); // 403 : you don't have permission
errorDump(req, ' viewer failed permission check!');
ErrorMSG(req, res, 'ERR_NO_PERMISSION', AD.Const.HTTP.ERROR_FORBIDDEN); // 403 : you don't have permission

} // end if
}
} // end if
}

}



////---------------------------------------------------------------------
var verifyParams = function (req, res, next) {
// Make sure all required parameters are given before continuing.
// Make sure all required parameters are given before continuing.

log(req, ' - verifyParams(): checking parameters');
log(req, ' - verifyParams(): checking parameters');


var listRequiredParams = {
// 'test':['exists','notEmpty','isNumeric'],
// 'test2':['notEmpty']
}; // each param is a string
var listRequiredParams = {
// 'test':['exists','notEmpty','isNumeric'],
// 'test2':['notEmpty']
}; // each param is a string

var objKey = req.aRAD.objKey;
switch(objKey) {
case 'object':
listRequiredParams = {
object_key:['exists','notEmpty'],
object_pkey:['notEmpty'],
object_table:['notEmpty']
}
break;
var objKey = req.aRAD.objKey;
switch(objKey) {
case 'object':
listRequiredParams = {
object_key:['exists','notEmpty'],
object_pkey:['notEmpty'],
object_table:['notEmpty']
}
break;

}
}

console.log(listRequiredParams);
console.log(req.params);
console.log(req.body);
console.log(listRequiredParams);
console.log(req.params);
console.log(req.body);

console.log('param():');
console.log(req.param('object_key'));
console.log('param():');
console.log(req.param('object_key'));


AD.Util.Service.validateParamsExpress(req, res, next, listRequiredParams);
AD.Util.Service.validateParamsExpress(req, res, next, listRequiredParams);
};



////---------------------------------------------------------------------
var create = function (req, res, next) {
// actually run the Model.findAll() method.
// actually run the Model.findAll() method.


var ModelName = req.aRAD.modelName;
var ModelName = req.aRAD.modelName;

log(req,' - '+ModelName+'.create()');
log(req,' - '+ModelName+'.create()');

var Object = req.aRAD.Object;
var params = {};
for (var q in req.query) {
params[q] = req.query[q];
}
for (var b in req.body) {
params[b] = req.body[b];
}
var Object = req.aRAD.Object;
var params = {};
for (var q in req.query) {
params[q] = req.query[q];
}
for (var b in req.body) {
params[b] = req.body[b];
}

$.when(Object.existing(params)).then(function(existing) {
if (!existing) {
Object.create(params, function(id) {
params.object_pkey = params.object_pkey || params.object_key + '_id';
params.object_table = params.object_table || 'hris_' + params.object_key;

log(req,' new id:'+ id);
req.aRAD.id = id;
next();

}, function(err) {
error(req, ' error finding results:');
errorDump(req, err);
ErrorMSG(req, res, 'ERR_CREATE', AD.Const.HTTP.ERROR_SERVER); // 500 : our end?
$.when(Object.existing(params)).then(function(existing) {
if (!existing) {
Object.create(params, function(id) {

});
} else {
req.aRAD.id = existing[Object.id];
next();
}
});
log(req,' new id:'+ id);
req.aRAD.id = id;
next();

}, function(err) {
error(req, ' error finding results:');
errorDump(req, err);
ErrorMSG(req, res, 'ERR_CREATE', AD.Const.HTTP.ERROR_SERVER); // 500 : our end?

});
} else {
req.aRAD.id = existing[Object.id];
next();
}
});

}

Expand All @@ -142,60 +146,60 @@ var create = function (req, res, next) {
//note: in below definitions, any value in [] is a templated value replaced with the instances value for that attribute: [id] = obj.id;
//note: params are defined like: params:{ requiredParam1:'[requiredParam1]', requiredParam2: '[requiredParam2]'}
var publicLinks = {
// findAll: { method:'GET', uri:'/hris/api/attributeset', params:{}, type:'resource' },
// findOne: { method:'GET', uri:'/hris/api/attributeset/[id]', params:{}, type:'resource' },
// create: { method:'POST', uri:'/hris/api/attributeset', params:{}, type:'action' },
// update: { method:'PUT', uri:'/hris/api/attributeset/[id]', params:{}, type:'action' },
// destroy: { method:'DELETE', uri:'/hris/api/attributeset/[id]', params:{}, type:'action' },
create: { method:'POST', uri:'/hris/api/[objectKey]', params:{}, type:'action' },
// findAll: { method:'GET', uri:'/hris/api/attributeset', params:{}, type:'resource' },
// findOne: { method:'GET', uri:'/hris/api/attributeset/[id]', params:{}, type:'resource' },
// create: { method:'POST', uri:'/hris/api/attributeset', params:{}, type:'action' },
// update: { method:'PUT', uri:'/hris/api/attributeset/[id]', params:{}, type:'action' },
// destroy: { method:'DELETE', uri:'/hris/api/attributeset/[id]', params:{}, type:'action' },
create: { method:'POST', uri:'/hris/api/[objectKey]', params:{}, type:'action' },
}

var urlCreate = publicLinks.create.uri.replace('[id]',':id').replace('[objectKey]', ':objKey');


var createStack = [
AD.App.Page.serviceStack, // authenticates viewer, and prepares req.aRAD obj.
ObjConst.findObject, // find out which object was specified on the url
hasPermission, // make sure we have permission to access this
verifyParams, // make sure all required params are given
create, // actually run object's create method
// step2, // get a list of all Viewers
// step3 // update each viewer's entry
AD.App.Page.serviceStack, // authenticates viewer, and prepares req.aRAD obj.
ObjConst.findObject, // find out which object was specified on the url
hasPermission, // make sure we have permission to access this
verifyParams, // make sure all required params are given
create, // actually run object's create method
// step2, // get a list of all Viewers
// step3 // update each viewer's entry
];


hrisObjectCreate.setup = function( app ) {

ErrorMSG = this.module.Error;
ObjConst.ErrorMSG = ErrorMSG; // this only needs to happen 1x ... right?
ErrorMSG = this.module.Error;
ObjConst.ErrorMSG = ErrorMSG; // this only needs to happen 1x ... right?

////---------------------------------------------------------------------
app.post(urlCreate, createStack, function(req, res, next) {
//app.get('/hris/apii/create/:objKey', createStack, function(req, res, next) {
// test using: http://localhost:8088/hris/api/attributeset
////---------------------------------------------------------------------
app.post(urlCreate, createStack, function(req, res, next) {
//app.get('/hris/apii/create/:objKey', createStack, function(req, res, next) {
// test using: http://localhost:8088/hris/api/attributeset


// By the time we get here, all the processing has taken place.
logDump(req, 'finished /'+urlCreate+' (create) ');
// By the time we get here, all the processing has taken place.
logDump(req, 'finished /'+urlCreate+' (create) ');


var Object = req.aRAD.Object;
var Object = req.aRAD.Object;

var returnPkt = {};
returnPkt[Object.id] = req.aRAD.id;
var returnPkt = {};
returnPkt[Object.id] = req.aRAD.id;

// send a success message
AD.Comm.Service.sendSuccess(req, res, returnPkt );
// send a success message
AD.Comm.Service.sendSuccess(req, res, returnPkt );

});
});




/*
////Register the public site/api
this.setupSiteAPI('attributeset', publicLinks);
*/
/*
////Register the public site/api
this.setupSiteAPI('attributeset', publicLinks);
*/

} // end setup()

41 changes: 0 additions & 41 deletions server/module_api/sub_Relationship.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,47 +119,6 @@ hrisRelationship.setup = function() {
}
hrisHub.subscribe('hris.Relationship.created', newRelationship);

/*
var deleteRelationship = function(event, data) {
console.log('======')
console.log(data)

var Relationship = AD.Model.List['hris.Relationship'];

var Object = AD.Model.List['hris.Object'];

Object.findOne({id:data.objA_id}, function(objA) {
Object.findOne({id:data.objB_id}, function(objB) {
// Delete reciprocal relationship
switch(data.relationship_type) {
case 'belongs_to':
var params = {objA_id: objB.object_id,
objB_id: objA.object_id,
relationship_type: 'has_many'};

Relationship.findAll(params, function(relationships) {
if (typeof relationships[0] != 'undefined') {
Relationship.destroy(relationships[0].relationship_id)
}
});
break;

case 'has_many':
var params = {objA_id: objB.object_id,
objB_id: objA.object_id,
relationship_type: 'belongs_to'};

Relationship.findAll(params, function(relationships) {
if (typeof relationships[0] != 'undefined') {
Relationship.destroy(relationships[0].relationship_id)
}
});
break;
}
});
});
}
*/
var deleteRelationship = function(event, data) {

var Relationship = AD.Model.List['hris.Relationship'];
Expand Down