Skip to content

fix: add engines field requiring node >= 22#91

Open
Thabettt wants to merge 1 commit into
apostrophecms:mainfrom
Thabettt:fix/add-node-engines
Open

fix: add engines field requiring node >= 22#91
Thabettt wants to merge 1 commit into
apostrophecms:mainfrom
Thabettt:fix/add-node-engines

Conversation

@Thabettt

Copy link
Copy Markdown

Added engines field to package.json specifying node >= 22.0.0. Refs apostrophecms/apostrophe#4645

Please indicate which branch this PR should merge into:

Check one

  • main
  • Check if this PR will be resubmitted against another branch

Summary

Added an engines field to package.json requiring node >= 22.0.0. This ensures users are warned about incompatible Node.js versions before installation. Refs apostrophecms/apostrophe#4645

What are the specific steps to test this change?

  1. Clone the repo and run npm install with Node.js 18 — confirm the EBADENGINE warning fires
  2. Run npm install with Node.js 22 or 24 — confirm no warnings appear

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • Build-related changes

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

Other information:
Change suggested by @boutell in apostrophecms/apostrophe#4645.

Added engines field to package.json specifying node >= 22.0.0. Refs apostrophecms/apostrophe#4645
Copilot AI review requested due to automatic review settings June 10, 2026 18:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a Node.js runtime requirement to the project to ensure consistent execution across environments.

Changes:

  • Declare a minimum supported Node.js version via package.json engines.node.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment on lines +41 to +43
"engines": {
"node": ">=22.0.0"
},

@boutell boutell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants