fix: add engines field requiring node >= 22#91
Open
Thabettt wants to merge 1 commit into
Open
Conversation
Added engines field to package.json specifying node >= 22.0.0. Refs apostrophecms/apostrophe#4645
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a Node.js runtime requirement to the project to ensure consistent execution across environments.
Changes:
- Declare a minimum supported Node.js version via
package.jsonengines.node.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+41
to
+43
| "engines": { | ||
| "node": ">=22.0.0" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added engines field to package.json specifying node >= 22.0.0. Refs apostrophecms/apostrophe#4645
Please indicate which branch this PR should merge into:
Check one
Summary
Added an
enginesfield topackage.jsonrequiringnode >= 22.0.0. This ensures users are warned about incompatible Node.js versions before installation. Refs apostrophecms/apostrophe#4645What are the specific steps to test this change?
npm installwith Node.js 18 — confirm the EBADENGINE warning firesnpm installwith Node.js 22 or 24 — confirm no warnings appearWhat kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
Other information:
Change suggested by @boutell in apostrophecms/apostrophe#4645.