Fix for RNG seeding of Lanczos input field for 5D red-black fields#143
Open
giltirn wants to merge 2 commits into
Open
Fix for RNG seeding of Lanczos input field for 5D red-black fields#143giltirn wants to merge 2 commits into
giltirn wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue stemming from the use of the 4D RNG to initialize the 5D red-black input field to ImplicitlyRestartedLanczos. When Grid detects a checkerboard output field, it creates a temporary full-grid field from its internal Grid then pulls the appropriate checkboard into the output. The issue is that the 4D RNG's internal Grid is 4D not 5D, so Grid throws an error when attempting to copy the 4D checkerboard into the 5D output field.