Adding content check to file-writing function to avoid unnecessary writes#2282
Open
fforres wants to merge 2 commits intoapollographql:masterfrom
Open
Adding content check to file-writing function to avoid unnecessary writes#2282fforres wants to merge 2 commits intoapollographql:masterfrom
fforres wants to merge 2 commits intoapollographql:masterfrom
Conversation
fforres
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever we run apollo type-generation, it writes every file that it finds regardless of the content of it.
In our case, we have project with over 1200 generated files, so running type-generation causes a few issues with type-checkers, or whenever we change a branch.
PR fixes part of the issues by doing a naive content-check before writing the files. Maybe this can be changed eventually to a content-hashing approach, but felt a bit out of scope for my fix.