Skip to content

Remove incorrect non-null assertion.#12089

Merged
jerelmiller merged 4 commits intomainfrom
pr/remove-non-null-assertion
Nov 11, 2024
Merged

Remove incorrect non-null assertion.#12089
jerelmiller merged 4 commits intomainfrom
pr/remove-non-null-assertion

Conversation

@phryneas
Copy link
Copy Markdown
Member

@phryneas phryneas commented Oct 7, 2024

This was erroring out in a upcoming TypeScript PR at microsoft/TypeScript#60068 (comment) - the non-null-assertion here is unnecessary and incorrect.

Thank you @Andarist for bringing it up.

No changeset since this doesn't touch runtime code or external types.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: a059cd0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-apollo-docs
Copy link
Copy Markdown

svc-apollo-docs commented Oct 7, 2024

✅ Docs Preview Ready

No new or changed pages found.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Oct 7, 2024

npm i https://pkg.pr.new/@apollo/client@12089

commit: a059cd0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 7, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 39.33 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 48.01 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 45.59 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.4 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.29 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.69 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.77 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.73 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.41 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.35 KB (0%)
import { useFragment } from "dist/react/index.js" 2.28 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.23 KB (0%)

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 7, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 04b674e
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/6703c1617fba5b00085dd858
😎 Deploy Preview https://deploy-preview-12089--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions Bot added the auto-cleanup 🤖 label Oct 7, 2024
Copy link
Copy Markdown
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jerelmiller
Copy link
Copy Markdown
Member

Should we have a changeset associated with this?

@Andarist
Copy link
Copy Markdown

Should we have a changeset associated with this?

This is purely an internal change - inconsequential for end users, so I'd say this doesn't need a changeset.

@phryneas
Copy link
Copy Markdown
Member Author

@jerelmiller quoting my initial post :)

No changeset since this doesn't touch runtime code or external types.

@jerelmiller
Copy link
Copy Markdown
Member

Gah if only I'd read a little closer 🤦🏻‍♂️. Thanks!

@jerelmiller jerelmiller merged commit 2eab7e0 into main Nov 11, 2024
@jerelmiller jerelmiller deleted the pr/remove-non-null-assertion branch November 11, 2024 22:21
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants