Skip to content

Ejecta now supports radial fills, so I unpatched BarGraph and moved it to the src folder. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
troydawson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ejecta now supports radial fills, so I unpatched BarGraph and moved it to the src folder. #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion App/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ ejecta.include("../libs/pitaru/ejecta-heart-createjs.js");

// WORKS ////
// These are Examples that work with minimal or no changes to the source code:
//ejecta.include("src/BarGraph.js");
//ejecta.include("src/Cache_vday.js");
//ejecta.include("src/Cache.js");
//ejecta.include("src/CacheUpdate.js");
Expand Down Expand Up @@ -55,7 +56,6 @@ ejecta.include("src/HelloWorld.js");

// PARTIALLY WORKS ////////
// These examples will run with limitted functionlality
//ejecta.include("src/partially_works/BarGraph.js");
//ejecta.include("src/partially_works/GraphicsTestTiny.js");
//ejecta.include("src/partially_works/BitmapAnimation.js");

Expand Down
6 changes: 1 addition & 5 deletions App/src/partially_works/BarGraph.js → App/src/BarGraph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
/*
Ejecta is missing beginLinearGradientFill (will be implemented soon). For now I marked out line 76 and added a beginFill on 87 instead
Ejecta supports linear gradient with https://github.com/phoboslab/Ejecta/commit/8a4814bd600aa362660401fbfa7bc568f2b70974
*/


var canvas;
var stage;
var barPadding = 7;
Expand Down Expand Up @@ -73,7 +72,6 @@ var canvas;
// draw the front panel of the bar, this will be scaled to the right size in drawBar:
var front = new createjs.Shape();

/*
front.graphics.beginLinearGradientFill(
[createjs.Graphics.getHSL(hue,100,60,0.9),
createjs.Graphics.getHSL(hue,100,20,0.75)],
Expand All @@ -82,8 +80,6 @@ var canvas;
-100,
barWidth,0).drawRect(0,-100,barWidth+1,
100);
*/
front.graphics.beginFill(createjs.Graphics.getHSL(hue,100,20,0.75)).drawRect(0,-100,barWidth+1,100);

// draw the top of the bar, this will be positioned vertically in drawBar:
var top = new createjs.Shape();
Expand Down