[pull] main from tower-rs:main#17
Merged
Merged
Conversation
* fix(services): handle trailing slash * fix(services): handle trailing slashes on file requests * fix(services): return 404 for file requests with trailing slash * test: add test for file request with trailing slash and fallback * fix(services): return 404 for single file requests with trailing slash * revert SingleFile changes * fix(services): correctly handle file requests with trailing slash This fixes the regression while preserving the correct behavior for: - Directories with trailing slash + `append_index_html_on_directories: true` - Root path `/` (with or without trailing slash) - Normal file requests We now explicitly reject file + trailing-slash early in `maybe_redirect_or_append_path` and use a `PathResolution` enum for clearer control flow. * satisfy clippy * remove redundant syscall * revert maybe_redirect_or_append_path to use Option
* refactor!: include grpc error message in tracing * Address review feedback on grpc error message extraction - Add #[repr(i32)] and #[non_exhaustive] to GrpcCode - Add #[non_exhaustive] to GrpcFailureClass - Fix behavioral regression: status codes >16 now correctly treated as non-success - Use decode_utf8_lossy() instead of discarding on invalid UTF-8 - Impl std::error::Error for GrpcFailureClass - Promote GrpcStatus methods to pub, add code_raw() and message() accessors - Export GrpcStatus from classify module - Add tests for percent-encoding, invalid UTF-8, unknown codes, and empty message * Make percent-encoding a required dependency and address review feedback - Remove cfg(feature = "trace") gate on percent-decoding: always use percent_decode().decode_utf8_lossy() for grpc-message extraction - Make percent-encoding a non-optional dependency to simplify the code - Add test for valid UTF-8 percent-encoded message - Add test that GrpcCode::Ok is classified as success via ClassifyResponse --------- Co-authored-by: Xiaoya Wei <xiaoya.wei@airbnb.com>
barjin
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )