Skip to content

Comments

Add JSDoc for basicContextPipeline getter in BasicCrawler#3437

Closed
Copilot wants to merge 2 commits intochore/more-context-pipelinefrom
copilot/sub-pr-3388-again
Closed

Add JSDoc for basicContextPipeline getter in BasicCrawler#3437
Copilot wants to merge 2 commits intochore/more-context-pipelinefrom
copilot/sub-pr-3388-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 24, 2026

Addresses a review request to document the basicContextPipeline getter, which was previously undocumented despite non-obvious design intent.

  • JSDoc added to basicContextPipeline getter explaining:
    • Why the pipeline is split: allows subclass crawlers to rerun this portion independently on the same basic context (e.g. AdaptiveCrawler retrying with a different crawler type)
    • The basic pipeline is side-effect-free, unlike subclass pipelines (which may e.g. launch a browser)
    • Typing intent: subclass pipelines expect basic crawler fields already present in the context at runtime

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: barjin <61918049+barjin@users.noreply.github.com>
Copilot AI changed the title [WIP] Add JSDoc for basicContextPipeline getter in BasicCrawler Add JSDoc for basicContextPipeline getter in BasicCrawler Feb 24, 2026
@barjin barjin closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants