Conversation
Contributor
janbuchar
commented
Feb 13, 2026
janbuchar
commented
- split from refactor!: Extract service management from Configuration into ServiceLocator class #3325 after review (refactor!: Extract service management from Configuration into ServiceLocator class #3325 (comment))
janbuchar
added
adhoc
barjin
reviewed
Feb 13, 2026
15 tasks
barjin
approved these changes
Feb 16, 2026
Member
barjin
left a comment
barjin
left a comment
There was a problem hiding this comment.
lgtm, thank you for looking into this!
| }); | ||
|
|
||
| // Preserve the url property (Response.url is read-only and the constructor ignores it) | ||
| Object.defineProperty(trackedResponse, 'url', { value: response.url }); |
Member
There was a problem hiding this comment.
See ResponseWithUrl class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.