fix: constructor options take precedence over env vars in Configuration#3384
Open
fix: constructor options take precedence over env vars in Configuration#3384
Conversation
B4nan
force-pushed
the
fix/config-priority-3080
branch
2 times, most recently
from
1348c85 to
2fb30c4
Compare
…on (#3080) Changes the configuration priority so that user-provided constructor options take precedence over environment variables, while env vars still override defaults and crawlee.json settings. New priority: constructor options > env vars > crawlee.json > defaults This allows users to programmatically override environment variables, e.g., `new Configuration({ headless: false })` now works even if CRAWLEE_HEADLESS=true. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
B4nan
force-pushed
the
fix/config-priority-3080
branch
from
2fb30c4 to
d6946be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crawlee.jsonsettingscrawlee.jsonwas incorrectly overwriting constructor optionsNew priority:
constructor options > env vars > crawlee.json > defaultsThis allows users to programmatically override environment variables. For example,
new Configuration({ headless: false })now works even ifCRAWLEE_HEADLESS=trueis set.Closes #3080
Test plan
🤖 Generated with Claude Code