feat: make Sessions exclusive for concurrent requests#3380
Draft
feat: make Sessions exclusive for concurrent requests#3380
Sessions exclusive for concurrent requests#3380Conversation
barjin
changed the title
SessionPool makes sessions usage exclusive for callersSessionPool makes session usage exclusive for callers
barjin
commented
Feb 3, 2026
|
|
||
| tryCancel(); | ||
|
|
||
| const session = this.useSessionPool |
Member
Author
There was a problem hiding this comment.
Idea - can we use the new ContextPipeline to inject the (exclusive) Session to the context - and unlock it in the cleanup? cc @janbuchar
barjin
changed the title
SessionPool makes session usage exclusive for callersSessions exclusive for concurrent requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple
SessionPool.getSession()calls will now return different session instances, untilSessionPool.reclaimSession(session)is called.If more sessions than
SessionPool.maxPoolSizeare retrieved,SessionPool.getSessionwill returnundefined.Crawlers now expect this and will throttle based on the session availability.
Closes #3270