Skip to content

docs: backport runnable code example fixes to v3 versioned docs#1004

Merged
vdusek merged 2 commits into
masterfrom
docs/backport-runnable-examples-v3
Jun 19, 2026
Merged

docs: backport runnable code example fixes to v3 versioned docs#1004
vdusek merged 2 commits into
masterfrom
docs/backport-runnable-examples-v3

Conversation

@vdusek

@vdusek vdusek commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Backports the documentation fixes from #1002 into the v3 versioned docs (website/versioned_docs/version-3.4/). The original PR only updated the next (docs/) docs, so the released v3 guides were left out of sync.

The changes were applied by extracting #1002's diff and re-pointing it at the versioned tree. Every touched file is now byte-identical to its docs/ counterpart.

What it carries over:

  • Lower the page cap from 50 to 10 across all crawling examples, so the browser-based ones finish within the 180s runnable-demo timeout.
  • Selenium: slim the runnable example to a plain crawler, and move the proxy-auth extension into a separate, non-runnable snippet (code/04_selenium_proxy.py).
  • Browser Use: make it non-runnable (needs an LLM API key the shared runner can't provide); same note added to the Scrapy and Scrapling-browser examples.
  • Pydantic: log a readable validation summary and fail cleanly via Actor.fail.

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jun 19, 2026
@vdusek vdusek self-assigned this Jun 19, 2026
@github-actions github-actions Bot added this to the 143rd sprint - Tooling team milestone Jun 19, 2026
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.61%. Comparing base (482e725) to head (15d446c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1004   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files          49       49           
  Lines        3171     3171           
=======================================
  Hits         2905     2905           
  Misses        266      266           
Flag Coverage Δ
e2e 35.69% <ø> (ø)
integration 56.41% <ø> (ø)
unit 80.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek requested a review from Pijukatel June 19, 2026 09:56
@vdusek vdusek marked this pull request as ready for review June 19, 2026 09:56
Scrapling's AsyncDynamicSession rejects a per-fetch proxy on a reused session
("Browser not initialized for proxy rotation mode"). Set the Apify Proxy URL on
the session at construction instead; Apify Proxy rotates the exit IP on its own.
Applied to both the current and the v3.4 versioned docs.
@vdusek vdusek merged commit e42e8c7 into master Jun 19, 2026
28 checks passed
@vdusek vdusek deleted the docs/backport-runnable-examples-v3 branch June 19, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants