Skip to content

test: deflake request queue aliases e2e test#1000

Open
vdusek wants to merge 1 commit into
masterfrom
test/deflake-rq-aliases-reboot
Open

test: deflake request queue aliases e2e test#1000
vdusek wants to merge 1 commit into
masterfrom
test/deflake-rq-aliases-reboot

Conversation

@vdusek

@vdusek vdusek commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

test_rq_aliases intermittently failed after the Actor reboot. The platform's batch-add endpoint is best-effort and can return a request as unprocessed; the singular add_request does not retry it (unlike add_requests), so the request was silently dropped and the post-reboot fetch_next_request returned None, failing the in-Actor assertion and the run.

This switches the two pre-reboot adds to add_requests, which retries unprocessed requests, so the requests reliably survive the reboot. Test-only change, mirroring the sibling deflake in #991.

`test_rq_aliases` intermittently failed after reboot because the platform's best-effort batch-add can return a request as unprocessed and the singular `add_request` does not retry it. Use `add_requests`, which retries unprocessed requests, so the added requests survive the reboot.
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jun 17, 2026
@vdusek vdusek self-assigned this Jun 17, 2026
@github-actions github-actions Bot added this to the 143rd sprint - Tooling team milestone Jun 17, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Jun 17, 2026
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.51%. Comparing base (726620b) to head (998230d).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
- Coverage   90.54%   90.51%   -0.04%     
==========================================
  Files          49       49              
  Lines        3132     3132              
==========================================
- Hits         2836     2835       -1     
- Misses        296      297       +1     
Flag Coverage Δ
e2e 36.14% <ø> (ø)
integration 57.12% <ø> (-0.04%) ⬇️
unit 79.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek

vdusek commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

If this is the intended behavior, we should just stabilize the test. If not, we should consider updating the add_request method (Apify storage client).

@vdusek vdusek marked this pull request as ready for review June 17, 2026 13:18
@vdusek vdusek requested a review from Pijukatel June 17, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants