test: deflake request queue aliases e2e test#1000
Open
vdusek wants to merge 1 commit into
Open
Conversation
`test_rq_aliases` intermittently failed after reboot because the platform's best-effort batch-add can return a request as unprocessed and the singular `add_request` does not retry it. Use `add_requests`, which retries unprocessed requests, so the added requests survive the reboot.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1000 +/- ##
==========================================
- Coverage 90.54% 90.51% -0.04%
==========================================
Files 49 49
Lines 3132 3132
==========================================
- Hits 2836 2835 -1
- Misses 296 297 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
If this is the intended behavior, we should just stabilize the test. If not, we should consider updating the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_rq_aliasesintermittently failed after the Actor reboot. The platform's batch-add endpoint is best-effort and can return a request as unprocessed; the singularadd_requestdoes not retry it (unlikeadd_requests), so the request was silently dropped and the post-rebootfetch_next_requestreturnedNone, failing the in-Actor assertion and the run.This switches the two pre-reboot adds to
add_requests, which retries unprocessed requests, so the requests reliably survive the reboot. Test-only change, mirroring the sibling deflake in #991.