Skip to content

fix: use static import for proxy-agent to fix Bun single executable bundling #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: use static import for proxy-agent to fix Bun single executable bundling #862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
167a2ab
Initial plan
Copilot Mar 11, 2026
fd8c20d
fix: use static import for proxy-agent to fix Bun single executable b…
Copilot Mar 11, 2026
d4c1259
Revert "fix: use static import for proxy-agent to fix Bun single exec…
barjin Mar 13, 2026
fa77a87
chore: simplify changes
barjin Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions rsbuild.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ export default defineConfig({
BROWSER_BUILD: true,
},
},
resolve: {
// proxy-agent is a Node.js-only package, exclude it from the browser bundle.
// The isNode() guard in http_client.ts ensures it's never called in browsers.
alias: {
'proxy-agent': false,
},
},
output: {
distPath: { js: '.' },
filename: { js: 'bundle.js' },
Expand Down
10 changes: 3 additions & 7 deletions src/http_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import type { RetryFunction } from 'async-retry';
import retry from 'async-retry';
import type { AxiosError, AxiosInstance, AxiosRequestConfig, AxiosResponse, InternalAxiosRequestConfig } from 'axios';
import axios, { AxiosHeaders } from 'axios';
import { ProxyAgent } from 'proxy-agent';

import { APIFY_ENV_VARS } from '@apify/consts';
import type { Log } from '@apify/log';
Expand Down Expand Up @@ -115,13 +116,8 @@ export class HttpClient {

private async initNode(): Promise<void> {
if (!isNode()) return;

const [{ ProxyAgent }, os] = await Promise.all([
// eslint-disable-next-line @typescript-eslint/consistent-type-imports
dynamicNodeImport<typeof import('proxy-agent')>('proxy-agent'),
// eslint-disable-next-line @typescript-eslint/consistent-type-imports
dynamicNodeImport<typeof import('node:os')>('node:os'),
]);
// eslint-disable-next-line @typescript-eslint/consistent-type-imports
const os = await dynamicNodeImport<typeof import('node:os')>('node:os');

// We want to keep sockets alive for better performance.
// Enhanced agent configuration based on agentkeepalive best practices:
Expand Down