This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Open
Conversation
realityking
force-pushed
the
common-js
branch
2 times, most recently
from
8097f81 to
bc0c959
Compare
realityking
force-pushed
the
common-js
branch
from
bc0c959 to
a3f9488
Compare
Author
|
Revisiting this PR, it doesn't seem like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CommonJS version of this module for the benefit of Node use-cases including
dredd.TBH I'm not sure why this package is build as an UMD module. I suspect this might be how it's deployed for Apiary UI? In that case this might require some change as the filename of the UMD build changes with this PR.
Not only is CommonJS code generating less closures than UMD, it also doesn't bundle all dependencies. This allows
dreddto load, for example,media-typeronly once.I also moved
urlto be a dev dependency as it's only used to build the UMD version. For Node.js the built-in version ofurlis preferred.