This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Open
Conversation
kylef
commented
Mar 1, 2021
| expect(variable).to.be.instanceof(MemberElement); | ||
| expect(variable.attributes.getValue('variable')).to.be.true; | ||
| expect(variable.value).to.be.instanceof(StringElement); | ||
| expect(variable.value.toValue()).to.be.undefined; |
Member
Author
There was a problem hiding this comment.
I was trying to see if we could "move" the example value here too, but it does get tricky quick due to the complexities when the schema for the additional properties could contain various constraints (fixed, fixedType, be a container, etc) which change what the "value" means.
I'll perhaps follow up with that when I get a chance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can extract the key to use for variable member derived from Schema Object
additionalPropertiesfrom an example, providing the key is not already used for a property (with different schema) or has different require-ness constraints.The change makes it so that the example in the following OpenAPI 2 Schema Object is not discarded when it matches the appropriate type, it is instead in the parse result: