Open
Conversation
40c88fb to
0f7d7f7
Compare
0f7d7f7 to
9ff2af7
Compare
a5952de to
12fe0da
Compare
IgnoredMethods has been renamed to AllowedMethods based on the Jenkins warnings here: https://test.apartmentlist.io/blue/organizations/jenkins/apartmentlist%2Fevent_tracker/detail/PR-305-head/9/pipeline/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config here is the result of a meeting where we all voted for each deviation from the default style guide.
Because each codebase uses inheritance over https, this PR needs to sit open until all the relevant codebases can be updated.
To add this to your codebase:
cdinto your project's directory.applystyles.shscript from this PR via/path/to/applystyles.shblue_steelgem, which you can safely remove.rubocoprun, you will need to manually fix them and re-runbundle exec rubocop -Pto see if they disappear..cifile has a Rubocop stage like the one in API. Optionally, you can remove the stuff about reports.