fix out-of-bounds read in HexBin for byte 0xff#33
Closed
aizu-m wants to merge 1 commit into
Closed
Conversation
Member
|
I raised https://issues.apache.org/jira/browse/XMLBEANS-665 This method is an internal method. Please don't use it as a hex utility. Find a better Java method. |
Member
|
thanks - d4e56ea merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isHex looks up hexNumberTable[octet & 0xFF] so the index can be 255, but the table is sized 255 (max index 254), so a 0xFF byte (a U+00FF char in xsd:hexBinary text) makes decode throw ArrayIndexOutOfBoundsException instead of returning null for non-hex input like it does for every other invalid byte. Sizing the table to 256 keeps the check inside the lookup table.